Repository navigation
Conversation
Resume the suspended async function with throw_flag when PromiseResolve, callback creation, or promise reaction allocation fails. Rejecting its outer promise directly skips catch and finally blocks around await. Add a regression test for exception identity, synchronous catch/finally execution, repeated failures, and recovery after a successful await. Fixes quickjs-ng#1757
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1757.
Errors while preparing await currently reject the async function's outer promise directly, skipping its catch and finally blocks. Resume the function with the pending exception instead, including errors from callback creation and promise reaction allocation.
The specification requires Await to propagate an abrupt completion from PromiseResolve, including a throwing promise.constructor getter:
For example:
Expected output: boom, then cleanup. Both blocks are skipped before the fix.
A finally block can also override the exception:
Validation: