feat: Run Promise hooks around promise continuation jobs - #1801
Open
nabetti1720 wants to merge 1 commit into
Open
nabetti1720 wants to merge 1 commit into
nabetti1720 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1740
Description of changes
This change emits
JS_PROMISE_HOOK_BEFOREandJS_PROMISE_HOOK_AFTERaround Promise reaction handler execution, passing the continuation Promise to both hooks.When a Promise hook is installed,
awaithandling creates a throwaway Promise capability for the continuation and associates it with the awaited Promise. When no hook is installed,awaitretains the existing allocation-free path.Compatibility limitation: To preserve this optimization, the continuation Promise is created only if a hook is installed when the await reaction is scheduled. If a hook is installed afterward,
BEFOREandAFTERstill fire when the reaction runs, but their Promise argument may beundefined.Tests cover hook invocation for
.then()andawait, including continuation Promise identity and its parent Promise.Validation:
cmake --build build --target api-test && ./build/api-test