Fix possible control-plane panic caused by race condition between reporting shard load and deleting index - #6762
Open
ncoiffier-celonis wants to merge 2 commits into
Open
Fix possible control-plane panic caused by race condition between reporting shard load and deleting index#6762ncoiffier-celonis wants to merge 2 commits into
ncoiffier-celonis wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On a test environment which uses Quickwit as a sidecar, and where I'm creating/deleting indices repeatedly, I think there is a possible race condition between reporting the shard load and deleting index, causing the control-plane actor to panic and to stay dead for ~30 seconds
This PR add 2 tests to show the problem, and fixes the
.expect("index should exist")that causes the panic.How was this PR tested?
Unit tests only