Skip to content

Remove emissions method availability exception from descriptions - #4763

Open
kndehaan wants to merge 3 commits into
masterfrom
emissions-dutch-regional
Open

kndehaan wants to merge 3 commits into
masterfrom
emissions-dutch-regional

Conversation

@kndehaan

@kndehaan kndehaan commented Jul 27, 2026

Copy link
Copy Markdown
Member

Context

With the 1990 and start year direct emissions data coming available for regional Dutch datasets, the descriptions in the front-end have been updated to not mention that the emission method is incomplete for those datasets.

Related

Goes with:

Checklist

  • I have tested these changes
  • I have updated documentation as needed
  • I have tagged the relevant people for review

- For new IPCC chart
- For original direct emissions chart in en_emissions
@jort-wolda

Copy link
Copy Markdown
Contributor

Had to rebase to master to run locally due to the switch to etlauncher. The new IPCC chart also that was rebased into this branch also had the line about direct emissions not yet being available for regional datasets. I deleted this.

I also noticed that in the en_emissions.yml, it still said the direct emissions method wasn't available for dutch regional datasets for the original direct emissions chart. Maybe this was overlooked or it happened due to the rebase. I deleted it now however.

One more side note, the docs still say: "Complete user output will first be available for national datasets and will later become availbale for regional (Dutch) datasets."

This is not part of this PR but maybe this should also be updated if everything's available for the regional datasets as well now.

@jort-wolda jort-wolda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, ran into an issue with rebasing to master to run locally. Had to do minor changes because of it. See comment.

Everything's good now

@kndehaan

Copy link
Copy Markdown
Member Author

Ready for final review by @mabijkerk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants