External coupling co2 emissions - #3487
Open
jort-wolda wants to merge 5 commits into
Open
Conversation
- Steel - Fertilizers transformations - Refineries transformations - Chemicals other transformations
3 tasks
Based on PR review Claude
kndehaan
reviewed
Sep 7, 2026
kndehaan
reviewed
Sep 7, 2026
kndehaan
reviewed
Sep 7, 2026
Member
|
General discussion points:
|
kndehaan
reviewed
Sep 8, 2026
Member
There was a problem hiding this comment.
Could you move the four input files to the folders of the sub sector they belong to? From a quick glance, it seems that the sub folders also represent the sub sector that is in coupling_groups. So then it seems more logic that the emissions input files are also put into the folder that represents their coupling group.
Member
|
From the general discussion points, I'll discuss the kton or Mton decision with the client. The scenario migration will be picked up. The other two points don't need any action. |
- Changed 'min_value' from 0 to 0.0 - Changed use for steel to energetic - Deleted scaling_exempt and explanation about scaling_exempt. Tested it and was indeed fine - Added a space in 'external_coupling_emissions_energy_chemical_other_transformation_co2.ad' for readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Implemented changes
External coupling co2 emissions:
Related
Goes with pull requests:
Checklist