Skip to content

Follow-up from #2085 review: stale Observability module card #2133

Closed

Description

@r3dbars

Minor (P2) items from the Codex review of #2085. Not blocking the merge; collected here so they don't get lost.

Activity

  1. added
    waiting-on-humanNeeds a human (Justin) to look before anything else happens
    cleanupOne-time repo cleanup
    on Oct 8, 2026
  2. r3dbars commented on Oct 17, 2026

    @r3dbars
    OwnerAuthor

    Already fixed on main. Commit b83446e ("Document resolved lower-module dependency seams", merged in #2173 on 2026-10-08) rewrote the Observability card in Sources/AGENTS.md. It dropped the whole "Grandfathered: ActivationTelemetry and AnalyticsEventPolicy name Dictation and Speech types" sentence, so both halves the review flagged are gone. The card now says Observability may depend on Support and Core core-vocab, and telemetry consumes plain values.

    Checked on current origin/main:

    • Sources/AGENTS.md, Sources/Observability/AGENTS.md and docs/repo-layout.md have no grandfathered-crossing text. The only hit for "grandfather" is "Nothing is grandfathered." in docs/repo-layout.md.
    • check-module-boundaries.py --explain Sources/Observability/AnalyticsEventPolicy.swift shows it may depend on Support and Core:core-vocab only. That matches the card.
    • No open PR touches Sources/AGENTS.md.

    No PR needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanupOne-time repo cleanupwaiting-on-humanNeeds a human (Justin) to look before anything else happens

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions