You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Follow-up from #2085 review: stale Observability module card #2133
Already fixed on main. Commit b83446e ("Document resolved lower-module dependency seams", merged in #2173 on 2026-10-08) rewrote the Observability card in Sources/AGENTS.md. It dropped the whole "Grandfathered: ActivationTelemetry and AnalyticsEventPolicy name Dictation and Speech types" sentence, so both halves the review flagged are gone. The card now says Observability may depend on Support and Core core-vocab, and telemetry consumes plain values.
Checked on current origin/main:
Sources/AGENTS.md, Sources/Observability/AGENTS.md and docs/repo-layout.md have no grandfathered-crossing text. The only hit for "grandfather" is "Nothing is grandfathered." in docs/repo-layout.md.
check-module-boundaries.py --explain Sources/Observability/AnalyticsEventPolicy.swift shows it may depend on Support and Core:core-vocab only. That matches the card.
Activity
r3dbars commentedon Oct 17, 2026
Already fixed on main. Commit b83446e ("Document resolved lower-module dependency seams", merged in #2173 on 2026-10-08) rewrote the Observability card in
Sources/AGENTS.md. It dropped the whole "Grandfathered:ActivationTelemetryandAnalyticsEventPolicyname Dictation and Speech types" sentence, so both halves the review flagged are gone. The card now says Observability may depend on Support and Corecore-vocab, and telemetry consumes plain values.Checked on current origin/main:
Sources/AGENTS.md,Sources/Observability/AGENTS.mdanddocs/repo-layout.mdhave no grandfathered-crossing text. The only hit for "grandfather" is "Nothing is grandfathered." indocs/repo-layout.md.check-module-boundaries.py --explain Sources/Observability/AnalyticsEventPolicy.swiftshows it may depend on Support and Core:core-vocab only. That matches the card.Sources/AGENTS.md.No PR needed.