Follow-up from #2122 review: Keep newer rename drafts open #2153

Activity

1. r3dbars

   added

   waiting-on-humanNeeds a human (Justin) to look before anything else happensNeeds a human (Justin) to look before anything else happens

   cleanupOne-time repo cleanupOne-time repo cleanup

   on Oct 8, 2026
2. r3dbars

   changed the title [-]Follow-up from #2122 review: Keep newer rename drafts open**[/-] [+]Follow-up from #2122 review: Keep newer rename drafts open[/+] on Oct 8, 2026
3. r3dbars commented on Oct 17, 2026

   

   r3dbars

   on Oct 17, 2026

   OwnerAuthor

   More actions

   Already fixed on main by 91ee05f ("Preserve speaker name edits made during a pending save"), which landed via #2173.

   • commitRename in Sources/UI/Settings/SpeakerPeoplePersonRow.swift captures submittedDraft before the save and, on completion, asks SpeakerEveryoneRenamePolicy.nameBox(afterSave:typed:submitted:) what to do. The card closes only when the live draft still equals the submitted one, so a newer draft typed during a slow save stays open.
   • acceptsSubmit(typed:saveInFlight:) ignores a second Return while a save is still running.
   • The close is also scoped to this card (expandedPersonID == id).
   • Tests/SpeakerVoiceRowPresentationTests.swift covers it: "An edit during an Everyone rename save stays available for a later save" (newer draft stays open after the first save succeeds, can be submitted once it finishes, and a failed save keeps it too).

   Verified on origin/main 86f4ce9: bash run-tests.sh --filter testSpeakerVoiceRowPresentation gave 42 passed, 0 failed. No new PR needed.
4. r3dbars

   closed this as completedon Oct 17, 2026