Repository navigation
chore: remove obsolete macOS 14 speaker harness checks - #2357
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The speaker evaluation package requires macOS 26, so its macOS 14 availability annotations and entry guard cannot exclude a supported run. This removes those obsolete checks without changing the command bodies.
Audit item: TOOLS-QA-13, remaining availability portion. The separate
embedder-debugusage correction is already in pending #2336 and is not duplicated here.Validation:
bash check.shpassed all 26 mapped commands, including a forced native dependency build, the harness build, andautoeval-self-test. Direct no-argument and missing-replay-argument runs still return the expected usage errors. No corpus, microphone, or model inference was run. Independent full-diff review againstorigin/main: GREEN, no findings.verify-change.shselected no app check and listed the five harness source files as uncovered. The build, synthetic evaluator self-test, and CLI usage checks cover this mechanical availability removal; real corpus behavior was not re-evaluated.