Repository navigation
docs(audio): align capture comments with current paths - #2414
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct four capture comment blocks against the current implementation:
stop()tostopSync().Every added or removed source line is a comment or blank line. No capture, engine/input-node, AirPods route, real-time callback, or other executable behavior changes. Independent full four-file diff/source review against
origin/main: GREEN from the coordinator before commit. No new tests are needed for factual comment changes.Validation on
1de98008a: 14 canonical mapped checks passed, including module/source-pin checks and concurrency typechecking. Five steps were explicitly BLOCKED with exit 3 by reviewed invocation guards: dependency/app builds, full fast tests, native integration smoke and unfiltered root package tests. Overallcheck.shresult is FAIL; exact-head receipt is clean and source-stable. Preflight passed. Guardedverify-change.shselected meetings and failed at the deliberately blocked app build; no native/audio/model/account run occurred. No app-build, full-suite, or hardware proof is claimed.Related: #2336 already proposes portions of these comment corrections. This separate issue PR leaves it untouched and unmerged, and also removes the old silence paragraph's incorrect synchronous-thread claim. Preserve unrelated hunks and avoid applying superseded comment hunks twice when integrating. No merge requested.