Repository navigation
refactor: remove unused menu bar helpers (UI-SHARED-10) - #2416
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
MenuBarMeetingCapturePhase.allowsStopand the no-argumentMenuBarHeaderView.intrinsicHeight, which have no app callers. Deletes the three tests of the unused stop helper. The live saving-state button policy, meeting action routing, and width-dependent header measurement stay in place.Addresses UI-SHARED-10 individually; the broader #2336 is left untouched.
Validation:
origin/main(8a38235e): GREEN. Confirmed real caller and saving-state paths.bash check.shwith a private safety guard: 19 mapped checks passed, including app build and concurrency census. The unfiltered fast suite returned explicit guard exit 3; overall result remains FAIL.verify-change.sh: app build passed; UI and launch-speed checks skipped because the owner's app is running. Nothing was quit; native behavior remains unproved.No product control or recording behavior was removed. No merge or release is requested by this draft.