Repository navigation
refactor: remove obsolete model polling constants (SUPPORT-15) - #2423
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model loading no longer polls, but its timeout was still defined as 600 iterations of a 200 ms poll interval. Replace those unused constants with the same
TimeIntervalbudget of 120 seconds. Keep the existing explicit 120-second promise test and remove the assertion that only repeated the old formula.Addresses SUPPORT-15 individually. All five production consumers keep the same name, type and value. No model loading, capture or timeout behavior changes.
Validation:
origin/main(8a38235e): GREEN.testTranscriptedConstants: 98/98 assertions passed.34ebcf253: guardedbash check.shhad 21 PASS and one explicit safety failure (unfiltered fast suite guard exit 3), overall FAIL. Source stable and clean; machine proof archived before the verifier.verify-change.sh: paste into the slow synthetic target passed; launch speed skipped because Transcripted is already running. No app was quit. This does not prove a real model download or model-load timing.The broader #2336 is unchanged. Draft pending remaining verification; no merge or release performed.