Skip to content

refactor: remove obsolete model polling constants (SUPPORT-15) - #2423

Merged
r3dbars merged 1 commit into
mainfrom
codex/review-support-15
Nov 12, 2026
Merged

r3dbars merged 1 commit into
mainfrom
codex/review-support-15

Conversation

@r3dbars

@r3dbars r3dbars commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Model loading no longer polls, but its timeout was still defined as 600 iterations of a 200 ms poll interval. Replace those unused constants with the same TimeInterval budget of 120 seconds. Keep the existing explicit 120-second promise test and remove the assertion that only repeated the old formula.

Addresses SUPPORT-15 individually. All five production consumers keep the same name, type and value. No model loading, capture or timeout behavior changes.

Validation:

  • Independent full two-file diff and production-caller review against fetched origin/main (8a38235e): GREEN.
  • Actual focused testTranscriptedConstants: 98/98 assertions passed.
  • Final committed head 34ebcf253: guarded bash check.sh had 21 PASS and one explicit safety failure (unfiltered fast suite guard exit 3), overall FAIL. Source stable and clean; machine proof archived before the verifier.
  • verify-change.sh: paste into the slow synthetic target passed; launch speed skipped because Transcripted is already running. No app was quit. This does not prove a real model download or model-load timing.
  • Exact-head hosted CI remains pending; this new head is outside the frozen Wave3 candidate.

The broader #2336 is unchanged. Draft pending remaining verification; no merge or release performed.

@r3dbars
r3dbars merged commit f082ad6 into main Nov 12, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant