Repository navigation
docs(logging): describe debug log trimming after appends - #2427
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
debug.logrotation comment and sink map say the byte threshold is checked only at session start. The existing actor also updates its tracked byte count after appends and calls the trimming path. Correct that timing in the writer comment, sink-table rotation cell and shared-mechanics paragraph.No executable code, thresholds, retention settings, payloads or privacy policy changes. Independent full two-file/three-hunk diff and actual-source review against
origin/main: GREEN from the coordinator before commit. No new runtime test is needed for these factual wording changes.Validation on
41d0412e4: 19 mapped source checks passed, including concurrency typechecking and analytics-emitter checks; app build and full fast tests were explicitly BLOCKED with exit 3 under reviewed invocation guards. Overall canonicalcheck.shresult is FAIL; raw exact-head receipt records clean/stable source. Preflight passed separately. The verifier SKIPPED speed because Transcripted was running; nothing was quit or launched. No logger instance, model/account workflow or real log read occurred. No runtime proof claimed.This extracts only OBSERVABILITY-9’s rotation wording from broad pending #2336. Excludes OBSERVABILITY-5’s memory-buffer/debug-panel/feedback wording and DOCS-19’s Writing row (#2419). The AppLogSink table row overlaps OBSERVABILITY-5 in a different column: retain both column edits when integrating. Broad #2336 remains untouched and unmerged. No merge requested.