Repository navigation
refactor: remove unused debug-log memory buffer (OBSERVABILITY-5) - #2429
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes AppLogSink's unused published
entriesbuffer and observable conformance. Production consumers only append to the local file; no view reads or observes these entries. Correct the debug-panel and feedback-email descriptions to match that behavior.Redaction tests now read the owned log file after writes finish. Ordering tests compare file output with the submitted messages, and empty-session coverage checks that only the session marker was written.
Addresses OBSERVABILITY-5 individually. Stacked on #2393 (
6f3361a14704e8008ca34b0c44f78489e1854d45) for its existing ordered-write/flush seam. Retarget this child before merging/deleting its parent branch. #2336 remains untouched; OBSERVABILITY-9 rotation wording and DOCS-19's Writing sink row are separate proposals.Validation:
origin/main(8a38235e): GREEN, including the owned fixture cleanup and actual feedbackrawLogLines: []caller.24e9e61fa: canonicalbash check.shhad 24 PASS, one explicit unfiltered-fast safety failure (exit 3), and an orchestration SKIP. Overall FAIL retained; source stable and clean. App build and concurrency census passed; raw proof archived.verify-change.shskipped launch speed because Transcripted is already running; nothing was quit.Draft pending remaining verification. No release or merge performed.