Skip to content

refactor: remove unused debug-log memory buffer (OBSERVABILITY-5) - #2429

Merged
r3dbars merged 1 commit into
mainfrom
codex/review-observability-5-buffer
Nov 12, 2026
Merged

r3dbars merged 1 commit into
mainfrom
codex/review-observability-5-buffer

Conversation

@r3dbars

@r3dbars r3dbars commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Removes AppLogSink's unused published entries buffer and observable conformance. Production consumers only append to the local file; no view reads or observes these entries. Correct the debug-panel and feedback-email descriptions to match that behavior.

Redaction tests now read the owned log file after writes finish. Ordering tests compare file output with the submitted messages, and empty-session coverage checks that only the session marker was written.

Addresses OBSERVABILITY-5 individually. Stacked on #2393 (6f3361a14704e8008ca34b0c44f78489e1854d45) for its existing ordered-write/flush seam. Retarget this child before merging/deleting its parent branch. #2336 remains untouched; OBSERVABILITY-9 rotation wording and DOCS-19's Writing sink row are separate proposals.

Validation:

  • Independent full child diff and full stack against fetched origin/main (8a38235e): GREEN, including the owned fixture cleanup and actual feedback rawLogLines: [] caller.
  • Actual focused suites: ObservabilityLogWriter 62/62 and AppLogSinkOrdering 5/5 assertions passed. Only invented data and owned temporary log files were used; no real logs read.
  • Exact head 24e9e61fa: canonical bash check.sh had 24 PASS, one explicit unfiltered-fast safety failure (exit 3), and an orchestration SKIP. Overall FAIL retained; source stable and clean. App build and concurrency census passed; raw proof archived.
  • Standalone preflight passed. verify-change.sh skipped launch speed because Transcripted is already running; nothing was quit.
  • Exact-head hosted checks remain pending. This new child is outside frozen Wave3.

Draft pending remaining verification. No release or merge performed.

Base automatically changed from codex/review-observability-10 to main November 12, 2026 22:13
@r3dbars
r3dbars merged commit 741c176 into main Nov 12, 2026
12 checks passed
@r3dbars
r3dbars deleted the codex/review-observability-5-buffer branch November 12, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant