Repository navigation
Fail tests when owned fixture setup cannot complete - #2435
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing file-size metadata or failure to open the owned migration fixture database should fail a test, rather than throw
XCTSkip. UseXCTUnwrapfor metadata and an explicit failure/non-skip error for the database. Preserve the existing SQLite close and all legitimate hardware/model/platform/corpus skips.This extracts the two verified direct-throw fixture cases from broad #2336. Cleanup for the selected synthetic fixtures now checks the canonical temporary parent and exact prefix/UUID leaf and reports removal failures; the migration cleanup helper is separate to keep its test file below 800 lines. No production or hardware behavior changed.
Validation: independent full classification diff and cleanup/source-safety reviews GREEN. Dependencies built successfully. Exactly one approved synthetic WAV method and one migration method passed (one test each, no failures/skips), with lab/live opt-ins removed and file logging disabled. These positive cases compile the changed helpers and check normal behavior; they do not prove injected setup-failure paths. No hardware or broader suite was executed.
Guarded canonical proof remains FAIL: 8 source checks PASS, five broader build/runtime commands deliberately blocked with exit 3, hardware smoke BLOCKED as manual proof. Raw clean/stable exact-head proof archived before verifier. Standalone preflight PASS; verifier selected no app check. Exact-head hosted/full-suite proof remains pending. MCP assertion-wrapped skip sites are unchanged and unclaimed.