Repository navigation
fix(qa): preserve layout for similarly named sibling paths - #2441
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
--patha sibling such asDocuments/Transcripted Backup/meetingscurrently inherits the legacyDocuments/Transcriptedstate and logs because layout inference compares raw string prefixes. Require an exact path or a/component boundary at all four layout/dictation checks. Genuine descendants and explicit state, log, and dictation overrides keep their existing behavior.Addresses TOOLS-QA-12. This extracts the underlying fix also pending in #2336 into its own small PR; that broader PR is untouched. Regression tests cover both legacy prefix siblings, both current-layout dictation prefix sites, genuine legacy descendants, and explicit overrides. Touched fixture cleanup now validates its canonical parent, UUID leaf, and real directory before removing it, and reports cleanup failures.
Validation: the new six-method fixture class compiled and produced six assertion failures against the original resolver, then all six methods passed with the reviewed fix restored. All resolver calls use an owned temporary home and empty environment. All 13 exact-head mapped checks passed on
a1da5916d, including the complete 110-test QA package and UI/QA contracts, test shape, module boundaries, file sizes, lint, and source pins. A separate actual preflight passed.verify-change.shselected no app check and listed the QA entrypoint as uncovered by its app-smoke map; the changed resolver itself is exercised through the owning package API by the focused red/green control and package suite. No native app proof is claimed. Independent coordinator review of the full diff and fixture safety: GREEN, no findings. No real library/default preferences, native app, SDK, model, or host actions.