Repository navigation
docs: run packaged app smoke from repository root (TOOLS-QA-4) - #2442
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The QA guide runs
packaged-app-smokefrom the package directory even though its default source plist, appcast, and build paths are resolved from the working directory. Move that example back to the repository root, select the package with--package-path, and adjust the explicit app/dSYM paths to that working directory.This main-based documentation correction extracts only TOOLS-QA-4 from broad pending #2336, which remains unchanged. The Swift CLI still defaults to
docs/appcast.xml; this PR does not fix that separate feed-selection behavior or prove the example passes for current release artifacts. Related #2426 changes a Python packaged-artifact checker, not this Swift CLI's appcast default. No new feed flag or dependency on #2426 is introduced. Existing native-account isolation rules are unchanged.Independent full-hunk and path-resolution source review: GREEN before commit at 9ace288.
bash check.sh: three static checks PASS; mappedswift test --package-path Tools/TranscriptedQAexplicitly BLOCKED (exit 3) by a reviewed invocation guard, so canonical deterministic proof remains FAIL. Source receipt is stable and clean. Standalone preflight passed;verify-change.shselected no app check. No package tests, packaged smoke, app build/launch, model, feed, or network proof was run; source inspection establishes only the working-directory correction.