Repository navigation
fix: display extended function and navigation key names - #2458
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepted F13–F20 and Control-Home/End/Page Up/Page Down shortcuts display numeric fallback labels in Settings and duplicate-binding messages. Add their twelve Carbon key names to the shared formatter. Capture, matching, admission, modifiers, stored bindings, and preferences are unchanged.
The new pure tests cover all twelve labels through both display paths, duplicate messages, and existing-name/modifier/unknown-key controls. One old-source baseline run failed 38 of 43 assertions while all five controls passed; restoring the reviewed fix passed 43/43 with a verified 1/1-function completion receipt. Those sources were committed unchanged. No preference-based HotkeyPreferencesTests were run.
Independent full production/test diff, SDK constants, real formatter callers, and fixture-safety review: GREEN before execution. This extracts only SUPPORT-6 from broad pending #2336, which remains unchanged; unrelated validator cleanup is separate #2450.
At exact head a9fcac9, canonical guarded checks recorded 18 PASS (including concurrency typecheck), with app build and unfiltered fast tests explicitly BLOCKED3, so that original receipt remains FAIL. Separate authorized
build.sh --no-openthen passed on the exact head with file logging disabled and launch smoke explicitly skipped. Its initial dependency-mtime refusal is preserved; the cache content digest exactly matched its stamp, so only the owned stamp timestamp was refreshed before rebuilding. No Core dependency rebuild was needed. Standalone preflight passed. Verifier speed SKIPPED because Transcripted is already running; nothing was quit.Real keyboard capture, native Settings rendering, and app launch remain unverified. No event taps, microphone, model, user preferences, or real user state were exercised.