Repository navigation
Remove unused retained speaker-name combo box - #2490
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses UI-SETTINGS-A-10 and its exact duplicate UI-SETTINGS-B-7 in one canonical PR.
Remove the unused
RetainedDataSourceComboBox, its dedicated lifetime fixture, its fast-source entry and the stale guide clause. The name field became anNSTextFieldin merged #2263; exhaustive tracked source/test/script/config references found no app caller for the combo box. The four currentSpeakerNameAutocompleteFieldcallers, suggestion behavior and Speakers review/rename/merge/delete flows are unchanged. The historical source-pin inventory retains its original conversion record and adds one factual retirement sentence so it no longer presents the removed fixture as live. Broad #2336 only acknowledges this component's lack of app users in the guide; this PR contains the standalone removal and leaves that broad PR untouched.Validation:
NSComboBox.bash check.sh: 25 PASS, one orchestration preflight SKIP, and full fast suite explicitly BLOCKED (exit 3), leaving the overall result FAIL. App build, strict-concurrency census, source lists, module boundaries, source pins and documentation paths passed. No baselines grew. Raw proof archived before verifier, bound to clean/stable headeb382b08a833f95bde429102051bc616736bdb2a.Actual native naming interaction remains unverified; no UI/audio/model/account flow was executed. No result from another head or frozen integration cut is claimed. No policy, merge or release change.