Repository navigation
refactor(meeting): remove unused suppression forwarder - #2520
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses MEETING-A-3. Remove the unused private two-argument
suppressRuntimePrompts(for:until:)forwarder. All six real calls pass an explicit reason to the unchanged three-argument implementation.Only four lines in
MeetingPromptDetector+Backoff.swiftare removed. The entire file is otherwise byte-identical to main. The unused snooze wrapper is a separate extraction in #2516; this branch leaves it intact. This is the corresponding issue-sized cleanup from unmerged broad draft #2336.Validation at
8e460a132c58552bd976648125db9041e4e275aa:bash check.sh: 16 PASS, including forced dependencies, actual app compilation and concurrency census. Full fast and integration suites were deliberately blocked (each exit 3); overall canonical proof remains FAIL. Exact-head clean/stable raw JSON archived before verification.verify-change.shexits 0 with meetings SKIP because Transcripted is already running. The owned app builds; no app is quit or launched. Its generic live-hardware advisory remains unknown.No prompt policy or protected user-facing flow changes. This draft is not a landed fix.