Skip to content

refactor(meeting): remove unused suppression forwarder - #2520

Merged
r3dbars merged 1 commit into
mainfrom
codex/review-meeting-a-3
Nov 12, 2026
Merged

r3dbars merged 1 commit into
mainfrom
codex/review-meeting-a-3

Conversation

@r3dbars

@r3dbars r3dbars commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Addresses MEETING-A-3. Remove the unused private two-argument suppressRuntimePrompts(for:until:) forwarder. All six real calls pass an explicit reason to the unchanged three-argument implementation.

Only four lines in MeetingPromptDetector+Backoff.swift are removed. The entire file is otherwise byte-identical to main. The unused snooze wrapper is a separate extraction in #2516; this branch leaves it intact. This is the corresponding issue-sized cleanup from unmerged broad draft #2336.

Validation at 8e460a132c58552bd976648125db9041e4e275aa:

  • Independent full diff, whole backoff implementation, all caller/method-value/selector references and detector export review: GREEN. Private Swift method, no Objective-C export or tracked two-argument caller.
  • No new test mirrors an unreachable forwarder. Actual Record / dismiss / remind wiring and active suppression logic are unchanged.
  • Guarded bash check.sh: 16 PASS, including forced dependencies, actual app compilation and concurrency census. Full fast and integration suites were deliberately blocked (each exit 3); overall canonical proof remains FAIL. Exact-head clean/stable raw JSON archived before verification.
  • Standalone preflight PASS. verify-change.sh exits 0 with meetings SKIP because Transcripted is already running. The owned app builds; no app is quit or launched. Its generic live-hardware advisory remains unknown.
  • Full QA bench refused at its outer invocation (exit 3), not run. Native detection, capture, owner preferences and mixed prompt suites were not exercised.

No prompt policy or protected user-facing flow changes. This draft is not a landed fix.

  • Exact-head hosted metadata: Repo Hygiene completed successfully, attempt 1. Swift CI was queued and Concurrency Census in progress at this check. This does not clear the local guard gaps or establish native behavior.

@r3dbars
r3dbars merged commit 4f8aee8 into main Nov 12, 2026
18 of 22 checks passed
@r3dbars
r3dbars deleted the codex/review-meeting-a-3 branch November 12, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant