Repository navigation
refactor(speech): remove unused local-model query - #2522
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses SPEECH-B-3. Remove the unused
ParakeetEngine.modelFilesAvailableLocallyproperty and its variant-query method. The only tracked reference to the method was the property itself; no caller uses either entry point.This removes exactly 20 lines from
ParakeetEngine.swift, matching the corresponding unmerged broad #2336 extraction. The rest of the file is byte-identical to main. Active model-cache state, readiness, model initialization, download, graph construction, device routing and recording paths are unchanged. With AirPods as default input, this cleanup adds no engine or input-node access and changes no routing policy.Validation at
4e513cf917c8e79713ff268e772ba1a2c9f2da59:bash check.sh: 17 PASS, including actual app compilation, strict concurrency census and source pins; unfiltered fast suite deliberately refused (exit 3). Overall canonical proof remains FAIL. Exact-head clean/stable raw JSON archived before verification.verify-change.shexits 0 with speed SKIP because Transcripted is already running; no app quit or launch. Its hardware advisory remains unknown.This is a draft proposal, not a landed fix.