Skip to content

refactor(speech): remove unused local-model query - #2522

Merged
r3dbars merged 1 commit into
mainfrom
codex/review-speech-b-3
Nov 12, 2026
Merged

r3dbars merged 1 commit into
mainfrom
codex/review-speech-b-3

Conversation

@r3dbars

@r3dbars r3dbars commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Addresses SPEECH-B-3. Remove the unused ParakeetEngine.modelFilesAvailableLocally property and its variant-query method. The only tracked reference to the method was the property itself; no caller uses either entry point.

This removes exactly 20 lines from ParakeetEngine.swift, matching the corresponding unmerged broad #2336 extraction. The rest of the file is byte-identical to main. Active model-cache state, readiness, model initialization, download, graph construction, device routing and recording paths are unchanged. With AirPods as default input, this cleanup adds no engine or input-node access and changes no routing policy.

Validation at 4e513cf917c8e79713ff268e772ba1a2c9f2da59:

  • Independent full diff, original file, callers/method-value/selector/export and actual model/initialization review: Infra GREEN; root GREEN. These are internal Swift members, with no Objective-C export.
  • No new test mirrors unreachable accessors. No engine, model, native capture or user preference store was instantiated for behavioral testing.
  • Guarded bash check.sh: 17 PASS, including actual app compilation, strict concurrency census and source pins; unfiltered fast suite deliberately refused (exit 3). Overall canonical proof remains FAIL. Exact-head clean/stable raw JSON archived before verification.
  • Standalone preflight PASS. verify-change.sh exits 0 with speed SKIP because Transcripted is already running; no app quit or launch. Its hardware advisory remains unknown.
  • Full QA bench refused at its outer invocation (exit 3), not run. Physical microphone, model download and Bluetooth behavior are not claimed verified.

This is a draft proposal, not a landed fix.

  • Exact-head hosted metadata: Repo Hygiene completed successfully, attempt 1. Swift CI was queued and Concurrency Census in progress at this check. This does not establish native or model behavior.

@r3dbars
r3dbars merged commit a4cb16b into main Nov 12, 2026
18 of 22 checks passed
@r3dbars
r3dbars deleted the codex/review-speech-b-3 branch November 12, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant