Skip to content

refactor(meeting): require host-owned capture audio - #2527

Merged
r3dbars merged 1 commit into
mainfrom
codex/review-meeting-a-10
Nov 12, 2026
Merged

r3dbars merged 1 commit into
mainfrom
codex/review-meeting-a-10

Conversation

@r3dbars

@r3dbars r3dbars commented Nov 10, 2026

Copy link
Copy Markdown
Owner

Addresses MEETING-A-10. Require an existing Audio when constructing MeetingCaptureBridge, removing its unused optional/default construction branch. The sole tracked constructor call already injects app-owned storage paths and the workspace sleep/wake notification source.

The bridge change matches the corresponding unmerged broad #2336 extraction. One caller comment is corrected to describe the host supplying that wiring. Callback setup, PCM relays, subscriptions, capture start/stop, storage paths and recording policies are unchanged. This adds no engine or input-node work and changes no Bluetooth-default handling.

Validation at ee8beb8d1335bdd65d68b6502fec5a3cc28d0b48:

  • Independent full two-file diff, whole bridge and routing extension, caller, constructor/method-value/selector and internal-API review: Tools GREEN; root GREEN. The caller file’s executable bytes are identical to main.
  • No new test mirrors an unreachable constructor branch. All tracked construction is explicit; this is an internal app adapter, not a public Core API removal.
  • Guarded bash check.sh: 16 PASS, including forced dependencies, actual app compilation, concurrency census and source pins. Full fast and integration suites deliberately refused (each exit 3); overall canonical proof remains FAIL. Exact-head clean/stable raw JSON archived before verification.
  • Standalone preflight PASS. verify-change.sh rebuilds the owned app and exits 0 with meetings SKIP because Transcripted is already running. No app quit or launch; its live-hardware advisory remains unknown.
  • Full QA bench refused at its outer invocation (exit 3), not run. No native capture, hardware, real user library or mixed-suite behavior proof is claimed.

This draft is not a landed fix.

@r3dbars
r3dbars merged commit 4b0e74f into main Nov 12, 2026
18 of 22 checks passed
@r3dbars
r3dbars deleted the codex/review-meeting-a-10 branch November 12, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant