Repository navigation
refactor(meeting): require host-owned capture audio - #2527
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses MEETING-A-10. Require an existing
Audiowhen constructingMeetingCaptureBridge, removing its unused optional/default construction branch. The sole tracked constructor call already injects app-owned storage paths and the workspace sleep/wake notification source.The bridge change matches the corresponding unmerged broad #2336 extraction. One caller comment is corrected to describe the host supplying that wiring. Callback setup, PCM relays, subscriptions, capture start/stop, storage paths and recording policies are unchanged. This adds no engine or input-node work and changes no Bluetooth-default handling.
Validation at
ee8beb8d1335bdd65d68b6502fec5a3cc28d0b48:bash check.sh: 16 PASS, including forced dependencies, actual app compilation, concurrency census and source pins. Full fast and integration suites deliberately refused (each exit 3); overall canonical proof remains FAIL. Exact-head clean/stable raw JSON archived before verification.verify-change.shrebuilds the owned app and exits 0 with meetings SKIP because Transcripted is already running. No app quit or launch; its live-hardware advisory remains unknown.This draft is not a landed fix.