Skip to content

DEAD-CODE-3: remove unused private reservation identity lookup - #2617

Draft
r3dbars wants to merge 1 commit into
mainfrom
codex/review-dead-code-3
Draft

r3dbars wants to merge 1 commit into
mainfrom
codex/review-dead-code-3

Conversation

@r3dbars

@r3dbars r3dbars commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Remove the unused reservedIdentity(at:) method from the private ReplacementTranscriptReservations class. The actual save path already obtains the bound capture ID through reservedExpectation(at:); reservation, identity protection and every public saveTranscript overload remain unchanged.

DEAD-CODE-3: the tracked repository's only reference was the declaration. The full file equals main minus this seven-line method; the unrelated public-overload removal in broad draft #2336 is excluded.

Validation at credited head 01dde52037a44a6cded18fd289cddb3318978ed0, against main 8a38235eef00816a79daa1324387a21ef880204d:

  • Root independent full-diff, whole private-owner and actual save-caller review GREEN; six committed input hashes match the reviewed bytes. No new tests for this unused private method.
  • bash check.sh: 16 PASS / 3 FAIL, overall FAIL. Owned dependency/app builds, strict concurrency over 740 app sources and mapped static checks passed. Isolation guards refused the full fast suite, integration smoke and package tests with exit 3; none ran.
  • Raw exact-head proof archived before verifier. Separate preflight PASS; head/input hashes stayed stable and the tree clean.
  • verify-change.sh rebuilt the owned app and exited 0; meetings SKIP because Transcripted was already running. No app was quit or launched, and its manual/hardware checklist was not performed.
  • Full QA bench refused before execution with exit 3. No file/library/preferences or native behavior was exercised. Hosted and combined-change CI remain pending, including other proposals touching TranscriptSaver.

Separate draft for this issue; no merge or release. Compilation and source review are not native or saved-library proof.

@r3dbars r3dbars added the needs owner review Owner must review before merge label Nov 11, 2026 — with ChatGPT Codex Connector

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs owner review Owner must review before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant