Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused
reservedIdentity(at:)method from the privateReplacementTranscriptReservationsclass. The actual save path already obtains the bound capture ID throughreservedExpectation(at:); reservation, identity protection and every publicsaveTranscriptoverload remain unchanged.DEAD-CODE-3: the tracked repository's only reference was the declaration. The full file equals main minus this seven-line method; the unrelated public-overload removal in broad draft #2336 is excluded.
Validation at credited head
01dde52037a44a6cded18fd289cddb3318978ed0, against main8a38235eef00816a79daa1324387a21ef880204d:bash check.sh: 16 PASS / 3 FAIL, overall FAIL. Owned dependency/app builds, strict concurrency over 740 app sources and mapped static checks passed. Isolation guards refused the full fast suite, integration smoke and package tests with exit 3; none ran.verify-change.shrebuilt the owned app and exited 0; meetings SKIP because Transcripted was already running. No app was quit or launched, and its manual/hardware checklist was not performed.Separate draft for this issue; no merge or release. Compilation and source review are not native or saved-library proof.