Skip to content

Remove unused screen-capture refresh plumbing (WRITING-RUNTIME-4) - #2654

Draft
r3dbars wants to merge 1 commit into
mainfrom
codex/review-writing-runtime-4
Draft

r3dbars wants to merge 1 commit into
mainfrom
codex/review-writing-runtime-4

Conversation

@r3dbars

@r3dbars r3dbars commented Nov 11, 2026

Copy link
Copy Markdown
Owner

The window OCR path always performs full-window OCR, but its text-field path still maintained a private refresh flag and forwarded a forceFullOCR argument that the leaf never read. This removes that unused plumbing and forwarding wrapper, calls the existing capture method directly, and inlines four unchanged literal values.

Covers WRITING-RUNTIME-4 only, extracted from the narrow source hunk in broad audit draft #2336 (4f99d388896c619c93b34b8727ace3428ee68203). That broad draft is provenance, not a landed fix. The separate Runtime10 cadence-comment hunk is excluded. Permission/privacy/target gates, cadence reservation, retry outcomes, AX-first extraction, full-window OCR, retention and late-result rejection stay in place. Public evidence vocabulary and the helper extension are unchanged.

Validation on c7734c43ae29d5e399ed7f26f407f235a9f0da0f:

  • Independent full actual diff review: GREEN. The reviewer read the entire actor and its sole helper extension, traced callers/outcomes, and verified all 17 base/current bindings. The committed source is associated with that review and the exact extraction proof.
  • No new test or mutation run for unused private plumbing deletion and identical literal substitution. Existing tests remain unchanged; this does not establish new behavioral test coverage.
  • Guarded bash check.sh: 16 PASS, 3 FAIL (exit 3 refusals for full fast, integration and root SwiftPM suites). Overall canonical FAIL retained. Actual forced dependency compilation, app compilation, strict concurrency census and mapped static checks passed. Raw canonical proof was archived before verification.
  • Standalone preflight: exit 0. Verification: exit 0 with actual owned app compilation; selected UI check SKIP because Transcripted was already running. The skip establishes no native UI/OCR proof. Full QA bench guard: exit 3; bench not executed.

Package/native/manual OCR, screenshot frequency, permission behavior and latency remain UNKNOWN. Other draft changes to the same screen-capture actor need combined merged-head CI. Separate draft to main with owner review required; no merge requested.

@r3dbars r3dbars added the needs owner review Owner must review before merge label Nov 11, 2026 — with ChatGPT Codex Connector

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs owner review Owner must review before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant