Skip to content

refactor(support): remove retired embedder UI copy (SUPPORT-10) - #2657

Draft
r3dbars wants to merge 1 commit into
mainfrom
codex/review-support-10
Draft

r3dbars wants to merge 1 commit into
mainfrom
codex/review-support-10

Conversation

@r3dbars

@r3dbars r3dbars commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Addresses the narrow cleanup in SUPPORT-10: removes unused speaker-embedder choice titles/summary and the unobserved change notification. This is the isolated one-file hunk from unmerged broad draft #2336.

The setter remains: three test call sites, including one in a loop, use it to seed real preference-resolution contracts. The preference key, raw model cases, defaults, environment precedence, model loading and separate speaker databases stay intact. No Settings or Speakers controls change. This does not claim the setter was removed.

Validation at head d8e1bbc86dd116b7492b35c057c13e01515081f0, against main 8a38235:

  • Independent full-diff, whole-owner and caller/reference review; exact candidate/committed blob association verified.
  • One guarded canonical check: 15 PASS / 1 FAIL, overall FAIL. The only failure is the full fast suite refused with exit 3. The real app build, strict-concurrency typecheck and mapped static checks passed.
  • Raw exact-head proof archived before preflight and verifier; both exited 0. Verifier's speed check was SKIP because Transcripted is already running; nothing was quit. Outer full bench was refused with exit 3.
  • Head/source stayed clean and stable. Existing preference tests were not run; CI execution remains pending. No preferences, model, database or native runtime fixture, --list, new assertion or mutation run was used.

Draft; needs owner review. No merge or release.

@r3dbars r3dbars added the needs owner review Owner must review before merge label Nov 11, 2026 — with ChatGPT Codex Connector

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs owner review Owner must review before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant