[r3dbars]

What this is

The second batch of review PRs, stacked on the #2530 integration (e66e3e4). 106 PRs (#2558–#2663) were opened after #2530 was frozen. Each one was triaged against the integration head and then got an independent second read. 83 turned out to be already inside #2530 or to be notes that only record a review finding, so they aren't here. This branch carries the rest.

Included (22 PRs)

Merged with --no-ff, so each PR's exact head is an ancestor: #2558, #2561, #2568, #2570, #2571, #2574, #2605, #2606, #2609, #2610, #2613, #2614, #2618, #2619, #2626, #2634, #2643, #2645, #2647, #2659, #2662.

#2646 landed as its child commit only (632b19bf7, cherry-picked with -x): Stop and recovery read the engine, input node and pinned refs under the audio graph lock. Its parent #2639 is not on this branch.

What they do, roughly:

• Bug fixes: meeting prompt accessibility labels kept in the island (Preserve meeting prompt accessibility labels in the island (UI-OVERLAY-A-3) #2570); audio retention confirmations no longer create a fake "recent insert" (Keep audio retry confirmations separate from text insertions (UI-OVERLAY-A-10) #2574); companion meeting start/stop attributed correctly (fix: attribute companion meeting start and stop origins (MEETING-A-11) #2610); Helium added to call-speaker reading (fix(meeting): include Helium in call-speaker AX eligibility (MEETING-B-3) #2662); pinned-mic ring pre-touched before the IOProc (fix(audio): initialize pinned-mic ring before IOProc (CORE-AUDIO-7) #2605).
• Less work on hot paths: browser shortcut classification cached across activations (fix: share browser shortcut classification across activations (MEETING-A-12) #2618); one process-inventory read per mic scan (fix: remove redundant cold mic-scan reads (MEETING-B-2) #2626); one header pre-scan per transcript for all speaker aliases (Batch speaker alias preflight scans (CORE-SPEAKER-11) #2659).
• Dead code removed: about 1,200 lines across UI, Writing, Speech and Meeting (UI-SETTINGS-A-5: remove unused transcript finder helpers #2558, Remove unused meeting-delete confirmation copy (UI-SETTINGS-A-6) #2561, cleanup(ui): remove unused dictation anchor plumbing (UI-OVERLAY-A-8) #2568, Remove unreachable mic-timeout consumer branches (SPEECH-A-5) #2606, Remove obsolete Speech availability guards below macOS 26 (SPEECH-A-8) #2609, Remove obsolete Home issue-reporting sheet and models (UI-SETTINGS-A-4) #2613, refactor: remove unused meeting onboarding copy (MEETING-B-8) #2614, refactor: remove retired dictation trigger cases (SPEECH-A-6) #2619, Remove unused ported app preferences (DEAD-CODE-11) #2634, cleanup: retire unused Writing status and progress APIs (WRITING-RUNTIME-6) #2643, Remove unused last-saved URL placeholder (DEAD-CODE-13) #2645), plus a shared diagnostic-name helper (Share diagnostic state names while preserving emitted values (APP-DICTATION-7) #2571).

Conflict resolutions and follow-up commits

• cleanup(ui): remove unused dictation anchor plumbing (UI-OVERLAY-A-8) #2568, Share diagnostic state names while preserving emitted values (APP-DICTATION-7) #2571, Remove obsolete Home issue-reporting sheet and models (UI-SETTINGS-A-4) #2613, Remove unused ported app preferences (DEAD-CODE-11) #2634: conflicts resolved toward the integration where it had deliberately changed the same code; details are in the merge commits.
• Comment and doc touch-ups after refactor: remove retired dictation trigger cases (SPEECH-A-6) #2619 and cleanup: retire unused Writing status and progress APIs (WRITING-RUNTIME-6) #2643.
• Remove obsolete Home issue-reporting sheet and models (UI-SETTINGS-A-4) #2613 deleted the last SettingsInlineActionButton( call in the Home files, so the matching source pin in UIAutomationSurfaceContractTests was removed.
• Review found the banned-calls matrix rule still watched the old file after Batch speaker alias preflight scans (CORE-SPEAKER-11) #2659 moved the guarded code; the rule now points at TranscriptFrontmatterScanner.swift.

Not included

• fix(audio): serialize recording artifact admission and Stop handoff (CORE-AUDIO-12) #2639 (2,700-line recording-artifact and Stop rewrite): conflicts with the audio work already in Draft: integrate all 225 frozen open Transcripted PRs #2530, stop() can return early and leave a start stuck, and it has no hardware proof. A small redo of its real race fixes is being prepared separately.
• Record the pending speaker-learning commit policy (CORE-REST-5) #2652, Ignore obsolete beta tokens and accept explicit build names (BUILD-CI-12) #2658: need an owner decision (speaker learning on failed meetings; build-beta.sh CLI).
• 83 others: already in Draft: integrate all 225 frozen open Transcripted PRs #2530 or record-only notes.

Checks (on this Mac, by the integrating agent)

• bash check.sh quick: PASS (113 passed).
• bash run-tests.sh: 54,340 of 54,341 passed before the pin fix; the one failure was the pin above. After the fix only the affected filter was rerun (85/85). The full fast suite was not rerun after that one-line test change.
• bash build.sh --no-open: PASS.
• TRANSCRIPTED_DISABLE_FILE_LOGGER=1 swift test: one failure in 714 Speaker tests (testInventoryCountsEachPersonsClipsMeetingsAndSpeech, fixture cleanup) while a build ran alongside. It passed 17/17 when rerun alone. Not quarantined and not fixed; none of these PRs touch it.
• Source pins, module boundaries, file size, telemetry keys, banned calls: PASS.

Four area reviewers read the combined diff. Three found nothing; the fourth found the matrix rule above, now fixed.

Not verified: anything on real audio hardware, and CI on this exact head (dispatched separately).

🤖 Generated with Claude Code