Repository navigation
feat(storage): automate graph disk cleanup and controlled legacy retirement - #153
Draft
rabii-chaarani wants to merge 62 commits into
Draft
rabii-chaarani wants to merge 62 commits into
rabii-chaarani wants to merge 62 commits into
Conversation
Guard producer effects and scoped runs with reference epochs. Keep optional cleanup failures from blocking committed reads, and report post-publication artifact cleanup separately. Experimental collector and validator prototypes remain excluded.
BREAKING CHANGE: database open helpers return GuardedDatabase and reject path forms whose native resource identity cannot be proven. Connections borrow the guarded handle; canonical Windows extended paths retain their namespace.
Fix PR #153 native failures with charged path-buffer storage, canonical macOS fixture parents and deterministic startup contention coverage. Spec: knowledge/architecture/graph-disk-cleanup-contract.md (DC-S2–DC-S4 rev 0.2; DC-S5 rev 0.1). Evidence: 334 selected native checks pass; formatting and workspace Clippy with warnings denied pass. Existing tracking: https://linear.app/rabii/issue/RAB-10; synchronization unavailable.
Preserve private-file sharing while validating metadata, release artifact child handles before directory publication, account actual path sizes, and preserve configuration reader cursors on Windows. Canonicalize generation-storage fixtures and retain real cooperative limits. Verification: 180 focused Darwin checks and all five generation-storage integration tests pass; formatting and workspace Clippy with warnings denied pass. Lossless extension recompression preserves the existing package cap. Native platform CI qualification remains required.
Use the cursor-preserving reader constructor for numeric spans as well as strings and complete configuration scanning. Add a regression for numeric fields while the caller cursor is nonzero.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft implements automatic graph disk cleanup and controlled legacy retirement.
Supported native platforms are macOS ARM64 and Windows x86_64. Linux and Intel macOS targets, release requirements, installer support and bundled extensions were removed as requested.
macOS runs three serial test cohorts. Windows uses four required serial groups per cohort on the runner temporary directory. Artifact production waits for every group.
The storage repair completes authenticated pending control transactions before role dispatch. Its interruption regression failed before the fix and passes afterward. Coordinator fixture snapshots now hold real worker/writer leases and require complete physical identities.
All twelve Windows native groups and the Windows release smoke passed on c1faa03. The latest fixture-only change narrowly retries pre-injection START failures after proven empty cleanup; other failures remain strict. Required CI and an independent macOS repeat are continuing on 6e1543b.
Current CI: https://github.com/rabii-chaarani/codebaseGraph/actions/runs/40189203041