Repository navigation
fix(storage): isolate macOS nested directory scan cursors (COD-52) - #157
Merged
Merged
Conversation
rabii-chaarani
marked this pull request as ready for review
October 27, 2026 07:26
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
rabii-chaarani
force-pushed
the
fix/cod-52-macos-nested-scans
branch
from
October 27, 2026 07:35
5e3e42f to
09059b0
Compare
rabii-chaarani
force-pushed
the
fix/cod-52-macos-nested-scans
branch
from
October 28, 2026 00:26
09059b0 to
2a392a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current follow-up — COD-101 diagnostics, cause still under investigation
Head
2ea86cfefb682c6351b25e22a9896dcc65f11ba9adds reviewed test-only origin-stage diagnostics and prints the receipt snapshot into retained CI logs. Current CI 40618031832 is pending. COD-101 evidence and limits.The original macOS unit failure occurred before durable-detach injection: successful primary publication lacked a complete observed origin receipt. Its cause is not yet reproduced or causally fixed. Existing assertions, optional production behavior and deletion authority are preserved. Current checkpoint passes 27/27 focused existing tests and strict workspace Clippy/format; fresh Sol/Max review found no confirmed P0–P3. Full native/current-head qualification and COD-101 acceptance remain open.
The qualification below applies to its explicitly named historical head; it is not a passing result for this follow-up.
Verified — approved COD-52 and COD-98 scopes
Head
5e3e42f48a55581ef75b25ba21732913089f664dpassed CI40457158678: 22/22jobs, all nativeMac/Windows cohorts, both artifactbuild/smoke jobs and requiredaggregate actually passed. Actual tested mergef61579940edfa3f3bf67ac6b2e7abbf04ea37cfbis Git-tree-identical to this head.Exact final qualification and named-case evidence · Evidence-only stacked PR160. Keeping evidence stacked preserves this passing implementation head. COD-52 and COD-98 are Done for their approved slices; this PR remains draft/unmerged because merge was not approved.
Changes
Verification/review
Actual named native cases pass on both platforms, including formerly failingchunk/reopen/PK/connector/search/control, jumbo row, Managed+Directackfailurepreservation/recovery, deterministicidentityoracle andsingletonstability, plusWindowsnestedscanandallnewMacregressions. Oldsourcecursorregressionsfailasexpected. LocalCOPY5/5,phaseunit13/13,deterministic3/3,strictworkspacealltargetsallfeaturesClippy+formatpass.
Fresh GPT-6.1Sol/High proposal reviews and GPT-6.1Sol/Max final source/hostedevidencereviews: no unresolvedconfirmedP0–P3 in boundedchanges. Source/binary/runnerhashes and actualpassrecords linked above; attachedtests/jobgreen alone notcounted.
Limits
No merge/deployment/packagepublication/servicerestart. OtherMaintenancepolicies/slices, COD-61cleanconsumer/minimumOS/shell/sourceinstallqualification,S09disposition andmaintaineraggregateclosure remainopen. Earlierlocalbroad1110case run is incomplete,notpassing; retainedcapturedCLIprerequisitefailure explained. OldWindows55PID/56events cause remainsunprovenwithoutmissingrawtrace. ExistingWindowsunusedwarnings arepreexisting,notneworhidden;noallplatformwarningfreeclaim. ConnectedolderrootScryermodel/graphlimitation preserved;noexactworktreemodel/verdictsfabricated. Dirtyusercheckoutuntouched.