Skip to content

fix(storage): isolate macOS nested directory scan cursors (COD-52) - #157

Merged
rabii-chaarani merged 6 commits into
mainfrom
fix/cod-52-macos-nested-scans
Oct 28, 2026
Merged

rabii-chaarani merged 6 commits into
mainfrom
fix/cod-52-macos-nested-scans

Conversation

@rabii-chaarani

@rabii-chaarani rabii-chaarani commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Current follow-up — COD-101 diagnostics, cause still under investigation

Head 2ea86cfefb682c6351b25e22a9896dcc65f11ba9 adds reviewed test-only origin-stage diagnostics and prints the receipt snapshot into retained CI logs. Current CI 40618031832 is pending. COD-101 evidence and limits.

The original macOS unit failure occurred before durable-detach injection: successful primary publication lacked a complete observed origin receipt. Its cause is not yet reproduced or causally fixed. Existing assertions, optional production behavior and deletion authority are preserved. Current checkpoint passes 27/27 focused existing tests and strict workspace Clippy/format; fresh Sol/Max review found no confirmed P0–P3. Full native/current-head qualification and COD-101 acceptance remain open.

The qualification below applies to its explicitly named historical head; it is not a passing result for this follow-up.


Verified — approved COD-52 and COD-98 scopes

Head 5e3e42f48a55581ef75b25ba21732913089f664d passed CI40457158678: 22/22jobs, all nativeMac/Windows cohorts, both artifactbuild/smoke jobs and requiredaggregate actually passed. Actual tested merge f61579940edfa3f3bf67ac6b2e7abbf04ea37cfb is Git-tree-identical to this head.

Exact final qualification and named-case evidence · Evidence-only stacked PR160. Keeping evidence stacked preserves this passing implementation head. COD-52 and COD-98 are Done for their approved slices; this PR remains draft/unmerged because merge was not approved.

Changes

  • COD-52, CBG-PLAT-01S01 R01/A01–A02: fresh cursor per pinned macOS directory traversal via anchored openat/RAII/identitycheck; fixedscratch/parser, namespaceauthority and cancellation preserved. Multi-batch nested/filtered exact-entry tests, interruption/public-root replacement and genuine terminal receipt child-veto/late-selection/cancel/retry regression. Specrev0.10, approval.
  • COD-98, CBG-COPY-01A3/A9 verification repair: separate approval. Debug processidentity cached once per nativehelper, neverperrequest/event. Replace all3historicalnumericPIDuniquenessassertions with samevalidatedprocessinstanceoracle; numericPID remainsdiagnostic. Sameprocessreuse/missing/malformedevidence stillfails. Loading/containment/dependencies/resources unchanged; allchunk/PK/connector/search/control/no-replay/ManagedDirectpreservation checksremain.

Verification/review

Actual named native cases pass on both platforms, including formerly failingchunk/reopen/PK/connector/search/control, jumbo row, Managed+Directackfailurepreservation/recovery, deterministicidentityoracle andsingletonstability, plusWindowsnestedscanandallnewMacregressions. Oldsourcecursorregressionsfailasexpected. LocalCOPY5/5,phaseunit13/13,deterministic3/3,strictworkspacealltargetsallfeaturesClippy+formatpass.

Fresh GPT-6.1Sol/High proposal reviews and GPT-6.1Sol/Max final source/hostedevidencereviews: no unresolvedconfirmedP0–P3 in boundedchanges. Source/binary/runnerhashes and actualpassrecords linked above; attachedtests/jobgreen alone notcounted.

Limits

No merge/deployment/packagepublication/servicerestart. OtherMaintenancepolicies/slices, COD-61cleanconsumer/minimumOS/shell/sourceinstallqualification,S09disposition andmaintaineraggregateclosure remainopen. Earlierlocalbroad1110case run is incomplete,notpassing; retainedcapturedCLIprerequisitefailure explained. OldWindows55PID/56events cause remainsunprovenwithoutmissingrawtrace. ExistingWindowsunusedwarnings arepreexisting,notneworhidden;noallplatformwarningfreeclaim. ConnectedolderrootScryermodel/graphlimitation preserved;noexactworktreemodel/verdictsfabricated. Dirtyusercheckoutuntouched.

@rabii-chaarani
rabii-chaarani marked this pull request as ready for review October 27, 2026 07:26
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T07:27:38.685639Z 5e3e42f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rabii-chaarani
rabii-chaarani added this pull request to stack #161 October 27, 2026 07:33
@rabii-chaarani
rabii-chaarani force-pushed the fix/cod-52-macos-nested-scans branch from 5e3e42f to 09059b0 Compare October 27, 2026 07:35
@rabii-chaarani
rabii-chaarani force-pushed the fix/cod-52-macos-nested-scans branch from 09059b0 to 2a392a1 Compare October 28, 2026 00:26
@rabii-chaarani
rabii-chaarani merged commit 62dcb10 into main Oct 28, 2026
27 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant