Repository navigation
ci: acknowledge an intentional API break with a label - #15
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Landing an intentional break meant either adding the symbol to
acknowledgedChanges, a commit plus a prune after merge, or merging over red. The second is one click, so red became the routine outcome for any PR touching the API and stopped carrying information. Applying thebreaking-changelabel now turns the check green: nothing to commit, nothing to prune, and the label records who decided.The line worth checking is the trigger, not the condition:
labeledandunlabeledare not in the default activity set, so without them applying the label would leave the check red until the next push, and "one click" would quietly be "one click plus an empty commit".unlabeledis there so removing the label puts red back.This only means something once
break-checkis a required check onprotect-main, which it is not yet. I will add it after this merges, so the required context exists in the form the ruleset expects.Known gap, deliberately not closed here:
policy-modestays off, so a PR can still acknowledge its own break by editingbreak-check.config.jsonin the same PR. The action's own docs recommend turning it on precisely when the check is a required gate. Filed rather than folded in.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.