Skip to content

chore: probe policy-mode with a self-acknowledged break (do not merge) - #18

Closed
jacekradko wants to merge 1 commit into
mainfrom
jacek/verify-policy-mode
Closed

jacekradko wants to merge 1 commit into
mainfrom
jacek/verify-policy-mode

Conversation

@jacekradko

@jacekradko jacekradko commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Throwaway. Breaks the API (AiRunEventBase.userId becomes required) and, in the same commit, adds acknowledgedChanges entries including a bare wildcard that would clear anything. With policy-mode on, the config is read from main, so this must still come back red. Closing without merging.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-09-10T12:36:01.149Z

Summary

Metric Count
Packages analyzed 1
Packages with changes 1
🔴 Breaking changes 1
🟡 Non-breaking changes 0
🟢 Additions 0

Warning
1 breaking change(s) detected - Major version bump required

🔴 Breaking changes index (1)

Every breaking change, up front. Full diffs are in the package sections below.

Package Subpath Change
@radkode/ai-kit ./telemetry AiRunEventBase.userId

@radkode/ai-kit

Current version: 0.3.1
Recommended bump: MAJOR → 0.4.0 (0.x: a breaking change ships in the minor position)

Subpath ./telemetry

🔴 Breaking Changes (1)

Changed: AiRunEventBase.userId
- userId?: string;
+ userId: string;

Breaking change in property AiRunEventBase.userId: Member is no longer optional


Report generated by Break Check

Last ran on 72d0ca7.

@jacekradko jacekradko added the breaking-change Intentional API break, acknowledged; turns API Check green label Sep 10, 2026
@jacekradko

Copy link
Copy Markdown
Contributor Author

Probe complete. With policy-mode on, the self-acknowledged break stayed red despite a bare wildcard in the PR's own acknowledgedChanges, and the breaking-change label still cleared it. verify is red because the probe deliberately breaks typecheck.

@jacekradko jacekradko closed this Sep 10, 2026
@jacekradko
jacekradko deleted the jacek/verify-policy-mode branch September 10, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Intentional API break, acknowledged; turns API Check green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant