Repository navigation
Conversation
`write(name, value, unless_exist: true)` deserializes the stored row to check whether it has expired. `deserialize_entry` returns nil when the payload can't be loaded (an old raw value, a payload from another coder, or a corrupt row), so the check raised `NoMethodError: undefined method 'expired?' for nil`. `read` already treats such a row as a miss, so treat it as missing here too and write the new value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write(name, value, unless_exist: true)raisesNoMethodError(undefined methodexpired?for nil) when the stored entry cannot be deserialized, for example an old raw value, a different serializer, or a corrupt row.readalready treats these as a miss.This treats a nil entry as missing, so the write goes through. I added a regression test.