Repository navigation
Return false when an unless_exist write fails - #323
Open
tadhgboyle wants to merge 1 commit into
Open
tadhgboyle wants to merge 1 commit into
tadhgboyle wants to merge 1 commit into
Conversation
Use the result of lock_and_write instead of marking a write successful before persistence. Cover handled write failures and avoid populating the local cache with an unpersisted value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
write(..., unless_exist: true)setswritten = trueinside thelock_and_writeblock, before the entry is persisted. If persistence then raises a handled database error,Failsafereturnsnil, butwrite_entryignores that result and still returnstrue.This also causes the local cache to retain a value that was never persisted. Callers using the return value to acquire a lock can proceed without owning it.
Fix
Derive
writtenfrom the result ofentry_lock_and_writeinstead of mutating it inside the block. A completed write returns its serialized payload and becomestrue; an existing unexpired entry or a handled failure returnsniland becomesfalse.Tests
Added regressions for:
falserather thantrue.