style: apply the current pre-commit hooks repo-wide - #39
Conversation
`rainix-sol / static` runs `pre-commit run --all-files` and has been red on every PR for reasons unrelated to the PR: two committed files no longer match what the current hook set produces, so the run reports "files were modified by this hook" and exits 1. The workflows are consumed at `@main` and the hooks come from the rainix devshell, so the formatters moved under a repo that did not. This is the formatting-only commit that re-syncs them: - `taplo` reindents the `REUSE.toml` `path` array from 4 spaces to 2. - `yamlfmt` drops the blank line after the SPDX header in `.coderabbitai.yaml`. No behaviour changes; the REUSE annotation covers the same paths. Closes #38 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe pull request applies formatting changes to ChangesFormatter alignment
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other · Severity of issue fixed: Medium 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolves the `REUSE.toml` conflict: #39 reindented the `path` array from four spaces to two, and this branch deletes the `.gas-snapshot` entry from it. Kept #39's two-space indentation for every remaining entry and dropped only the `.gas-snapshot` line, so the diff against main is the one deletion. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Picks up #39 (pre-commit formatter re-sync) and #40 (stale .gas-snapshot deletion), which is what `rainix-sol / static` was red on: this branch predates the REUSE.toml/.coderabbitai.yaml formatting fix and the job's `pre-commit run --all-files` step reformatted them on every run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Closes #38.
rainix-sol / staticis red on every PR for reasons unrelated to the PR. Itspre-commit run --all-filesstep reformats committed files, so the run reports"files were modified by this hook" and exits 1. This is repo-wide drift: the
workflows are consumed at
@mainand the hook set comes from the rainixdevshell, so the formatters moved under a repo that did not.
This is the formatting-only commit that re-syncs them.
What changed
taploreindents theREUSE.tomlpatharray from 4 spaces to 2.yamlfmtdrops the blank line after the SPDX header in.coderabbitai.yaml.Nothing else. The REUSE annotation covers exactly the same paths.
Correction to the issue as filed
The issue reports four drifted files, adding
.vscode/settings.jsonandslither.config.jsonvia a failingprettier-rainix. That half does notreproduce.
prettier-rainixpasses both in CI and locally at the rainix rev CIactually resolved, and only two files drift.
CI on PR #37, run 35505454642, job
rainix-sol / static:with a shown diff touching
.coderabbitai.yamlandREUSE.tomlonly. Localpre-commit run --all-filesonmainat5c165a8, insidenix develop github:rainlanguage/rainix/8657b83b68f41957ab85da91132c3f652c1f32c0#sol-shell(the same rev CI resolved), reproduces the same two hooks and a byte-identical
diff.
git status --porcelainafterwards is exactly:The other three
staticsteps --slither .,forge fmt --checkandforge lint -D warnings-- pass on that run, so the whole failure is thepre-commit step, as the issue says.
Verification on this branch
Same devshell, same command, after the change:
git status --porcelainis empty afterwards, so the hook set is now a fixedpoint on this tree rather than merely quiet once.
Reverting each changed file to its base bytes, one at a time, and re-running the
whole hook set:
git checkout main -- REUSE.tomlgit checkout main -- .coderabbitai.yamlEach file is killed by exactly one hook and by no other, so neither half of the
diff is inert and neither is doing the other's work.
prettier-rainixsurvivesboth, which is the direct check on the issue's four-file claim.
Note for the reviewer
The fix for #36 also edits the
REUSE.tomlpatharray (it removes the.gas-snapshotentry). Both branches are cut frommainas asked, so whichevermerges second will conflict in that array. The resolution is mechanical: keep
the 2-space indent from this PR, minus the
.gas-snapshotline.QA
pre-commit run --all-filesin the pinned rainix devshell: taplo Failed + yamlfmt Failed on base, all hooks Passed and a cleangit status --porcelainon this branch. Both runs transcribed above.REUSE.toml-> reverted to base bytes -> killed by taplo alone;.coderabbitai.yaml-> reverted to base bytes -> killed by yamlfmt alone. Full table above. Neither half of the diff is inert, andprettier-rainixsurvives both.8657b83b68f41957ab85da91132c3f652c1f32c0, the same rev the failing CI run resolved from@main. The formatting here was produced by running them, not written by hand, and is byte-identical to the diff CI printed in run 35505454642. Independent of any judgment of mine about what the files should look like.staticstops being red for PR-independent reasons, (b) four named files are the drift, (c) the fix ispre-commit run --all-filescommitted as a formatting-only change. Covered (a) and (c). (b) is corrected, not covered: only two of the four drift, per the mutation table. The issue's separate observation thatslither .andforge fmt --checkpass is confirmed by run 35505454642 and needs no change.🤖 Generated with Claude Code
Summary by CodeRabbit