audit: record the adversarial mutation-test scan of 5c165a8

[thedavidmeister]

Campaign bookkeeping, split out of #37 so each concern stands on its own PR.
Branched off main, depends on nothing, and is independently mergeable.

What

One file: audit/mutation-test-scans.json, a record of the whole-repo
adversarial mutation-test scan at
5c165a880ac105d6c038cee096500f76849a2190 — 59 behaviours probed, 28 tests
before and 38 after, and the four issues the scan filed (#33, #34, #35, #36).

Why

So a later scan can tell what was already probed, at which commit, with which
tool and skill version, instead of re-deriving it. Without the record the next
run has no way to distinguish "this behaviour was probed and killed" from "this
behaviour was never looked at."

Scope

This closes no issue and is tied to none. It is a scan log: no source
change, no test change, no behaviour change, nothing executable. It is being
sent on its own precisely because it is not coverage and should not ride along
with tests that are.

audit/**/ is already covered by REUSE.toml, so the file needs no SPDX header
of its own and the legal job is unaffected.

QA

• Discriminating tests: n/a — this diff adds one JSON data file and no
  executable code. There is no behaviour for a test to discriminate, so a
  discriminating test here would be meaningless rather than merely absent.
• Mutations applied: n/a — nothing in this diff is reachable by the test
  suite. Mutating any byte of a scan record changes no program behaviour and no
  assertion, so every mutant would be equivalent by construction.
• Oracle: the scan run itself. Every field is transcribed from the
  adversarial-mutation-test (skill 0.35.0) run over
  5c165a880ac105d6c038cee096500f76849a2190 that produced it — the commit under
  scan, the tests-before/after counts, and the issue numbers it filed, which are
  checkable against Frozen-record check cannot see a release dropped from the declaration when two releases share bytecode #33, The candidate source anchor can be made self-comparing, and the suite stays green #34, Currency check cannot detect a generator that has stopped emitting a file #35 and .gas-snapshot is stale and no CI job regenerates or checks it #36 as actually filed on this repo.
• Category check: no issue drives this PR, and it claims none — it is a scan
  output and the ruling is one PR per issue, so it is sent alone rather than
  attached to unrelated coverage. The two concerns it used to ship with in test: cover the deploy declaration's metadata #37
  are now test: cover the deploy declaration's metadata #37 itself (the declaration-metadata tests) and test: give the open-salt entry points an oracle independent of the library #45 (the open-salt
  oracle; the issue it closes is The open-salt entry points have no test oracle independent of the library under test #43).

The testsAfterCommit field, and why it is not here

The first push of this branch went red on rainix-sol / static, and the
failure was real rather than incidental:

ERROR: audit/mutation-test-scans.json[0].testsAfterCommit:
70d4e18886c0b681e1d632d7153c1642fb3266e3 is not an ancestor of HEAD

rainix-static mutation-ledger requires every SHA a record names to be an
ancestor of HEAD, because "what changed since the last mutation run" is
otherwise computed against a tree this history does not contain. 70d4e18 is a
commit on the branch behind #37. It was an ancestor only while the scan record
and the tests shared one branch — which is exactly the bundling this split
undoes.

The field has been dropped, not repointed. It is optional by design: the gate
validates it when present and never requires it, and its module doc says why —
"the only way to go green would be to invent a SHA, which is the fabricated
evidence this gate exists to catch." Repointing it at a commit on this branch
would be that invention.

Everything the gate requires is present and valid: commit 5c165a8 is an
ancestor of this branch (verified with git merge-base --is-ancestor), the
timestamp is well-formed YYYY-MM-DDTHH:MM:SSZ, tool matches the expected
adversarial-mutation-test, and scope / summary are intact.

summary.testsAfter: 38 is still accurate for the run: 28 before, plus the 5
declaration tests on #37 and the 5 open-salt tests on #45.

QA

• Discriminating tests: n/a — this diff adds one JSON data file and no
  executable code. There is no behaviour for a test to discriminate, so a
  discriminating test here would be meaningless rather than merely absent. The
  file's own correctness is gated by rainix-static mutation-ledger in CI,
  which this PR is now green on.
• Mutations applied: n/a — nothing in this diff is reachable by the Solidity
  test suite. Mutating any byte of a scan record changes no program behaviour
  and no assertion, so every mutant would be equivalent by construction.
• Oracle: the scan run itself. Every field is transcribed from the
  adversarial-mutation-test (skill 0.35.0) run over
  5c165a880ac105d6c038cee096500f76849a2190 that produced it — the commit under
  scan, the tests-before/after counts, and the issue numbers it filed, which are
  checkable against Frozen-record check cannot see a release dropped from the declaration when two releases share bytecode #33, The candidate source anchor can be made self-comparing, and the suite stays green #34, Currency check cannot detect a generator that has stopped emitting a file #35 and .gas-snapshot is stale and no CI job regenerates or checks it #36 as actually filed on this repo. The
  ledger's shape is checked against rainix-static mutation-ledger, which is
  independent of the record.
• Category check: no issue drives this PR, and it claims none — it is a scan
  output and the ruling is one PR per issue, so it is sent alone rather than
  attached to unrelated coverage. The two concerns it used to ship with in test: cover the deploy declaration's metadata #37
  are now test: cover the deploy declaration's metadata #37 itself (the declaration-metadata tests) and test: give the open-salt entry points an oracle independent of the library #45 (the open-salt
  oracle; the issue it closes is The open-salt entry points have no test oracle independent of the library under test #43).

Checks

The diff contains no Solidity, so nothing here can move the build or the suite.
Verified anyway, locally in the pinned rainix sol-shell on this branch off
current main: 28 non-chain tests pass, 0 failed — main's count exactly,
unchanged, as a file with no executable content should leave it.
forge fmt --check passes and git status --porcelain is empty after
forge build, so the git-clean currency job is unaffected. audit/**/ is
already covered by REUSE.toml, so legal is too.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c37999c3-5c89-4a44-b1fe-820f5297bee5

📥 Commits

Reviewing files that changed from the base of the PR and between 3c19a6a and 69474ef.

📒 Files selected for processing (1)

• audit/mutation-test-scans.json

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}