docs: name which side of the library/deploy split a version, tag or report is on - #192
Merged
Merged
Conversation
…eport is on Soldeer `rain-factory` 0.1.5 and earlier carry the concrete `CloneFactory` and its deploy pins; 0.1.6 dropped them. The five tags on the pre-split side are named in README.md, and audit/protofire/ gets a README saying each report audits the ref its filename names and that neither V4 file is in any of them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The audit note repeated the three refs its filenames already carry and restated the split the root README states. "not revisions of this library" repeated "are those pre-split releases". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…t README Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #111
The
rain-factorySoldeer series and this repo's tag namespace both runcontinuously across the library/deploy split, and the three Protofire PDFs in
audit/protofire/all name refs from the pre-split side. Nothing in the reposaid which side of the cut a version, a tag or a report belongs to, so a reader
could resolve any of them to source that is no longer here and conclude audited
or deployed code is the code they are reading.
README.md— one paragraph fixing the version and tag boundary: Soldeerrain-factory0.1.5 and earlier carry the concreteCloneFactoryand itsdeploy pins, 0.1.6 dropped them, and the five pre-split tags are named.
audit/protofire/README.md— new: each report audits the ref its filenamenames, none covers the current tree, and
ICloneableFactoryV4/LibICloneableFactoryV4postdate all three.REUSE needs no change:
REUSE.toml:11already annotatesaudit/**/.QA
src/behaviourchanges, and tests never assert README text.
git ls-tree -r sol-v0.1.5(c29d5827309d2f10a6e68c76bc2ea385e0a4e701)carries
src/concrete/CloneFactory.sol,src/lib/LibCloneFactoryDeploy.sol,src/generated/0_1_{3,4,5}/andscript/Deploy.sol;sol-v0.1.6(
1b6adb965ac527ef114ddda11f4dad65400dbeeb) carries none of them. The Soldeerregistry lists
rain-factory0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.5, then 0.1.6through 0.1.23 — one ascending series across the cut.
pdftotextonrain.factory.sol-v0.1.5-r3.0.jul-2026.pdfgives its own Reviews table(
1a92a868…,08fecb98…tagv0.1.1,c29d5827…tagsol-v0.1.5) and itsScope list (
src/concrete/CloneFactory.sol,src/interface/ICloneableFactoryV2.sol,ICloneableFactoryV3.sol,ICloneableV2.sol,src/lib/LibCloneFactoryDeploy.sol) — neither V4 file isin it, and neither existed:
ICloneableFactoryV4landed 2026-08-08,LibICloneableFactoryV42026-08-20, both after the newest report.other side of the split". The other two carriers of that category are the
deployed factory's embedded library version ([F06] [MEDIUM] The live CloneFactory embeds rain-factory 0.1.9 while this repo publishes 0.1.23, and nothing here detects the gap #110) and the CI/tag mechanism
that let a surface removal ship as a patch bump. The first is [F06] [MEDIUM] The live CloneFactory embeds rain-factory 0.1.9 while this repo publishes 0.1.23, and nothing here detects the gap #110's; the
second is rainix's — the autopublish lifecycle and its
next-v<x.y.z>tag areowned by
rainix-autopublish.yaml, so a gate on "published surface changedwithout a minor tag" belongs in that reusable, not in a repo-local workflow
here.
🤖 Generated with Claude Code