docs: scope the live-CloneFactory claims to the revision it pins - #194
Merged
thedavidmeister merged 4 commits intoSep 21, 2026
Merged
Conversation
The deployed `CloneFactory` lives in `rain.factory.deploy` and embeds the `rain-factory` revision that repo pins, which can lag this head. The README, CLAUDE.md and the `LibICloneableFactoryV4` NatSpec each asserted the equivalence unconditionally, so a reader could take a guard documented here as present on chain. Closes #110 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The library header carried its split's issue number, a claim about the test suite, and two paragraphs arguing why the derivations live in one place and what `msg.sender` is read for — all visible in the code below it or stated on `ICloneableFactoryV4`. The README and CLAUDE.md paragraphs restated the interface spec and named the deployed pins twice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…live-factory-revision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #110
Problem
The deployed
CloneFactoryis not this repo's code. It lives inrain.factory.deploy,which inlines
rain-factoryby versioned import prefix and moves that pin onlyon a manual
sol-v*tag, while this repo autopublishes a patch bump on everycontent-changing merge.
README.md:20-22,CLAUDE.md:19-20andsrc/lib/LibICloneableFactoryV4.sol:50-51asserted the equivalence with noqualifier, so a reader could take a guard documented at this head as present on
chain.
The gap is live today.
rain.factory.deploymain pinsrain-factory = "0.1.9"—
sol-v0.1.9isc1c2afd3d88405d3228cb3b21e55c9d63ba8f5be(2026-08-20),against this head's 0.1.23. The runtime code at
0xAb9741E6f843452D649FCa35899d8F9A36e7DcA8contains neitherDelegatedImplementation()(0xe6f6d6de, the EIP-7702 /0xefrejection, #73)nor
CloneAddressOccupied(address)(0x134a0bbc, #74), both of which this headdocuments and implements, along with the
InitializationFailedwidening fornon-conforming
initializeanswers (#61).Not affected: the salt derivations, domain tags and predicted clone addresses.
git diff sol-v0.1.9 origin/main -- src/interface/ICloneableFactoryV4.solisNatSpec plus an import-path move, so an address predicted against the live
factory is still correct.
Fix
Three short scopings — each claim now names the revision it is about, rather
than being dropped or backed by a guard, per the owner rulings. No behaviour
change.
What this repo cannot fix
rain.factory.deploy: bump therain-factorypin, fix the versioned import prefixes, cover the new errors,cut a
sol-v*release and redeploy. Filed there asThe deployed CloneFactory embeds rain-factory 0.1.9 and is missing the 7702, occupied-address and initialize-answer changes rain.factory.deploy#42.
rainix-autopublish.yamlreusable that.github/workflows/package-release.yamlalready calls, not in a workflowhere. It must alert, never block: a publish that waits on a downstream bump
deadlocks on alternating merges and leaves main red on both repos.
rainix-static soldeer-gatealready performs the normalized published-zipcomparison the check needs. Filed as rainix-autopublish cannot see that a downstream repo pins a many-revisions-old copy of what it just published rainix#393.
QA
README text, so there is no test this diff could make fail on base.
src/edit is NatSpecabove the
librarykeyword; the compiled library is byte-identical.cast code 0xAb9741E6f843452D649FCa35899d8F9A36e7DcA8on Ethereum mainnet, Base andArbitrum One, compared byte for byte against
rain.factory.deploy's frozensrc/generated/0_1_10/CloneFactory.solRUNTIME_CODEand against this head'serror selectors.
category (
grep -in deploy README.md CLAUDE.md, plusdeployed|live|on-chain|rain-factory-deployacrosssrc/) and those threeare the complete set. The issue's fourth part — the structural drift detector
— is covered by rainix-autopublish cannot see that a downstream repo pins a many-revisions-old copy of what it just published rainix#393 rather than here, per the shared-CI
ruling.
🤖 Generated with Claude Code