CLAUDE.md: name the two path lists a new non-source file must join - #243
Open
thedavidmeister wants to merge 1 commit into
Open
thedavidmeister wants to merge 1 commit into
thedavidmeister wants to merge 1 commit into
Conversation
A non-source file carries no SPDX header. It is licensed by a path entry in `REUSE.toml`, which `reuse lint` gates, and kept out of the published package by `.soldeerignore`, which nothing gates. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114
"All source files must include SPDX headers" was the whole licensing
instruction, and it covers only the files that carry a header.
reuse lintis arequired gate —
.github/workflows/rainix-sol.yamlcalls rainix'srainix-sol.yaml, whoselegaljob runs it — and it covers every tracked file,not just source.
The repo licenses its non-source files through a hand-maintained path list in
REUSE.toml(16 entries:.gas-snapshot,.github/workflows/**/,CLAUDE.md,foundry.toml,flake.nix, …). A session adding a new root-level or configfile gets a red
reuse lintand nothing told it where the fix goes.The same file also has to be listed in
.soldeerignoreor it ships inside thepublished
rain-factorypackage. Nothing gates that at all, so it failssilently. #52 previously removed stale entries from exactly these two lists,
which is the evidence that they are maintained by hand and drift.
CLAUDE.md is 3906 bytes on this branch against the 4096
agent-context-cap(3807 on main). With all seven CLAUDE.md fixes from this audit batch landed it
comes to 4048.
Textual overlap with the PR closing #164. That one rewrites the second
sentence of this same paragraph (the SPDX header content); this one appends a
third. Both branch off
mainand each stands alone; I mergemainintowhichever lands second and resolve.
QA
never assert doc text.
src/ortest/code changed.REUSE.tomland.soldeerignoreas they stand in the tree, andrainlanguage/rainix/.github/workflows/rainix-sol-legal.yamlfor the gate.README.mdcarries nolicensing or packaging instruction, so there is no second copy to correct. The
inverse defect — entries in these lists naming paths that no longer exist —
was Remove the submodule-era residue —
REUSE.tomland.soldeerignorestill namefoundry.lockand.gitmodules, neither of which exists #52 and is already closed.🤖 Generated with Claude Code