CLAUDE.md: state both routes the tests take into the library - #248
Open
thedavidmeister wants to merge 1 commit into
Open
thedavidmeister wants to merge 1 commit into
thedavidmeister wants to merge 1 commit into
Conversation
`TestCloneFactory` exposes only the four `ICloneableFactoryV4` entry points, so the library's internal pure and view units are unreachable through it and are called directly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
"Tests exercise the library through
TestCloneFactory, a pure-delegationconcrete" names one of two routes as the route.
test/concrete/TestCloneFactory.solexposes only the fourICloneableFactoryV4entry points, so the library'sinternal pure/viewunits —
effectiveSalt,effectiveOpenSalt,cloneCreationCode,predictCloneAddress,checkImplementationCode— are unreachable through it.Seven of the eight test files call
LibICloneableFactoryV4.<fn>directly forthat reason.
A session adding a test for one of those units was told to route it through a
concrete that cannot reach it, and would either add an entry point the library's
own surface does not have or conclude the unit is untestable.
The replacement states both routes and what picks between them: the concrete
exists because
msg.sendernamespacing and theNewCloneevent are observableonly across an external call. "Pure-delegation concrete" is dropped from this
sentence —
TestCloneFactory's own NatSpec says it at length, and CLAUDE.md isunder a byte cap.
CLAUDE.md is 3836 bytes on this branch against the 4096
agent-context-cap(3807 on main). With all seven CLAUDE.md fixes from this audit batch landed it
comes to 4048.
Textual overlap with the PR closing #112.
deno fmtreflows the whole Build& Test paragraph as one unit, and that PR rewrites the sentences before this
one, so the two hunks overlap however the wording is arranged. Both branch off
mainand each stands alone; I mergemaininto whichever lands second andresolve.
QA
never assert doc text.
src/ortest/code changed.test/concrete/TestCloneFactory.sol's declared surface againstsrc/lib/LibICloneableFactoryV4.sol's function list, and the call sites intest/src/**.README.mddescribes the interfaces and the library butmakes no claim about how the tests reach them, so CLAUDE.md held the only copy
of this claim.
🤖 Generated with Claude Code