Skip to content

CLAUDE.md: state both routes the tests take into the library - #248

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-09-21-issue-117-test-routes
Open

thedavidmeister wants to merge 1 commit into
mainfrom
2026-09-21-issue-117-test-routes

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Closes #117

"Tests exercise the library through TestCloneFactory, a pure-delegation
concrete" names one of two routes as the route.
test/concrete/TestCloneFactory.sol exposes only the four
ICloneableFactoryV4 entry points, so the library's internal pure/view
units — effectiveSalt, effectiveOpenSalt, cloneCreationCode,
predictCloneAddress, checkImplementationCode — are unreachable through it.
Seven of the eight test files call LibICloneableFactoryV4.<fn> directly for
that reason.

A session adding a test for one of those units was told to route it through a
concrete that cannot reach it, and would either add an entry point the library's
own surface does not have or conclude the unit is untestable.

The replacement states both routes and what picks between them: the concrete
exists because msg.sender namespacing and the NewClone event are observable
only across an external call. "Pure-delegation concrete" is dropped from this
sentence — TestCloneFactory's own NatSpec says it at length, and CLAUDE.md is
under a byte cap.

CLAUDE.md is 3836 bytes on this branch against the 4096 agent-context-cap
(3807 on main). With all seven CLAUDE.md fixes from this audit batch landed it
comes to 4048.

Textual overlap with the PR closing #112. deno fmt reflows the whole Build
& Test paragraph as one unit, and that PR rewrites the sentences before this
one, so the two hunks overlap however the wording is arranged. Both branch off
main and each stands alone; I merge main into whichever lands second and
resolve.

QA

  • Discriminating tests: n/a — CLAUDE.md is process documentation, and tests
    never assert doc text.
  • Mutations applied: n/a — no src/ or test/ code changed.
  • Oracle: test/concrete/TestCloneFactory.sol's declared surface against
    src/lib/LibICloneableFactoryV4.sol's function list, and the call sites in
    test/src/**.
  • Category check: README.md describes the interfaces and the library but
    makes no claim about how the tests reach them, so CLAUDE.md held the only copy
    of this claim.

🤖 Generated with Claude Code

`TestCloneFactory` exposes only the four `ICloneableFactoryV4` entry points, so
the library's internal pure and view units are unreachable through it and are
called directly.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: fce2aced-28f6-423f-b967-fb286c30fd68

📥 Commits

Reviewing files that changed from the base of the PR and between 710dff5 and fad37bb.

📒 Files selected for processing (1)
  • CLAUDE.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[F13] [LOW] CLAUDE.md claims tests reach the library through TestCloneFactory; most test files call it directly

1 participant