CLAUDE.md: scope the no-concrete-contract claim to src/ - #249
Open
thedavidmeister wants to merge 1 commit into
Open
thedavidmeister wants to merge 1 commit into
thedavidmeister wants to merge 1 commit into
Conversation
`test/concrete/` holds six contracts, one of which the same file names two paragraphs later. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #118
CLAUDE.md stated "no concrete contract, no deploy pins, no deploy script" as a
flat property of the repository. Line 30 of the same file calls
TestCloneFactory"a pure-delegation concrete", andtest/concrete/holds sixof them:
TestCloneFactory,TestCloneable,TestCloneableCallRecorder,TestCloneableFailure,TestCloneableRawAnswer,TestCloneableRevert.grep '^contract\|^abstract contract' src/returns nothing, so the claim istrue of
src/only. The doc already scopes a sibling claim that way ("Nosrc/file imports from outside this repo"); that scoping word is what was missing
here.
Taken literally, the unscoped claim either pushes a needed test fixture concrete
out to
rain.factory.deployor reads the existingtest/concrete/tree as aviolation to clean up.
The issue also proposed appending "test-support concretes live in
test/concrete/". Not taken: once the claim is scoped it says nothing abouttest/, so the sentence adds no correction, and the same file namesTestCloneFactorytwo paragraphs later. CLAUDE.md is under a byte cap.CLAUDE.md is 3812 bytes on this branch against the 4096
agent-context-cap(3807 on main).
QA
never assert doc text.
src/ortest/code changed.src/andtest/concrete/as they stand — no contract declaredin the former, six in the latter.
test/falsifies. The deploy-half paragraph, the Soldeer bullet and theimports sentence are each already scoped or true as written; this was the only
one stated flat against the whole repo.
README.mdmakes the same point butas a description of
rain.factory.deploy's contents rather than a claim aboutthis repo.
🤖 Generated with Claude Code