Skip to content

CLAUDE.md: scope the no-concrete-contract claim to src/ - #249

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-09-21-issue-118-src-scoped-claim
Open

thedavidmeister wants to merge 1 commit into
mainfrom
2026-09-21-issue-118-src-scoped-claim

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Closes #118

CLAUDE.md stated "no concrete contract, no deploy pins, no deploy script" as a
flat property of the repository. Line 30 of the same file calls
TestCloneFactory "a pure-delegation concrete", and test/concrete/ holds six
of them: TestCloneFactory, TestCloneable, TestCloneableCallRecorder,
TestCloneableFailure, TestCloneableRawAnswer, TestCloneableRevert.

grep '^contract\|^abstract contract' src/ returns nothing, so the claim is
true of src/ only. The doc already scopes a sibling claim that way ("No src/
file imports from outside this repo"); that scoping word is what was missing
here.

Taken literally, the unscoped claim either pushes a needed test fixture concrete
out to rain.factory.deploy or reads the existing test/concrete/ tree as a
violation to clean up.

The issue also proposed appending "test-support concretes live in
test/concrete/". Not taken: once the claim is scoped it says nothing about
test/, so the sentence adds no correction, and the same file names
TestCloneFactory two paragraphs later. CLAUDE.md is under a byte cap.

CLAUDE.md is 3812 bytes on this branch against the 4096 agent-context-cap
(3807 on main).

QA

  • Discriminating tests: n/a — CLAUDE.md is process documentation, and tests
    never assert doc text.
  • Mutations applied: n/a — no src/ or test/ code changed.
  • Oracle: src/ and test/concrete/ as they stand — no contract declared
    in the former, six in the latter.
  • Category check: swept CLAUDE.md for other unscoped repo-wide claims that
    test/ falsifies. The deploy-half paragraph, the Soldeer bullet and the
    imports sentence are each already scoped or true as written; this was the only
    one stated flat against the whole repo. README.md makes the same point but
    as a description of rain.factory.deploy's contents rather than a claim about
    this repo.

🤖 Generated with Claude Code

`test/concrete/` holds six contracts, one of which the same file names two
paragraphs later.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a2472eb6-0955-4f3e-b5c1-dc2f73e73db1

📥 Commits

Reviewing files that changed from the base of the PR and between 710dff5 and 74b4470.

📒 Files selected for processing (1)
  • CLAUDE.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[F14] [LOW] CLAUDE.md's repo-wide "no concrete contract" claim contradicts its own TestCloneFactory line and the six concretes in test/concrete/

1 participant