Skip to content

CLAUDE.md: a source file carries two SPDX lines, not one - #251

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-09-21-issue-164-spdx-two-tags
Open

thedavidmeister wants to merge 1 commit into
mainfrom
2026-09-21-issue-164-spdx-two-tags

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Closes #164

"All source files must include SPDX headers" states no header content. Every
.sol in the repo carries two lines, not one:

// SPDX-License-Identifier: LicenseRef-DCL-1.0
// SPDX-FileCopyrightText: Copyright (c) 2020 Rain Open Source Software Ltd

Checked across all 19 tracked .sol files — both lines present, byte-identical,
in every one.

reuse lint fails a file carrying only the identifier, and the identifier alone
is the shape written from this instruction, since solc itself warns about
nothing else. The copyright holder string is not derivable from the sentence, so
a session had no way to produce a passing file from the doc.

The sentence now says a .sol copies the two lines its siblings carry. The
issue proposed spelling both strings out inline; pointing at the siblings is
shorter, cannot go stale if the holder string ever changes, and leads to the
same two lines. CLAUDE.md is under a byte cap, which is why the shorter form
wins.

CLAUDE.md is 3829 bytes on this branch against the 4096 agent-context-cap
(3807 on main). With all seven CLAUDE.md fixes from this audit batch landed it
comes to 4048.

Textual overlap with the PR closing #114. That one appends a third sentence
to this same paragraph (the REUSE.toml / .soldeerignore path lists for
non-source files); this one rewrites the second. Both branch off main and each
stands alone; I merge main into whichever lands second and resolve.

QA

  • Discriminating tests: n/a — CLAUDE.md is process documentation, and tests
    never assert doc text.
  • Mutations applied: n/a — no src/ or test/ code changed.
  • Oracle: the 19 tracked .sol files' first two lines, and REUSE.toml's
    annotation block, which supplies the same two fields for the non-source files.
  • Category check: README.md carries no licensing instruction, and the
    deprecated interfaces' own headers carry the two lines like every other
    .sol, so this sentence was the only place the header shape was stated.

🤖 Generated with Claude Code

Every `.sol` in the repo opens with `SPDX-License-Identifier` and
`SPDX-FileCopyrightText`. `reuse lint` fails a file carrying only the first, and
the copyright holder string is not derivable from the sentence that was there.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0fbb4dff-d702-4326-9467-55f883b68e11

📥 Commits

Reviewing files that changed from the base of the PR and between 710dff5 and ba203b5.

📒 Files selected for processing (1)
  • CLAUDE.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[F60] [LOW] CLAUDE.md's SPDX rule names one tag where REUSE requires two

1 participant