CLAUDE.md: a source file carries two SPDX lines, not one - #251
Open
thedavidmeister wants to merge 1 commit into
Open
thedavidmeister wants to merge 1 commit into
thedavidmeister wants to merge 1 commit into
Conversation
Every `.sol` in the repo opens with `SPDX-License-Identifier` and `SPDX-FileCopyrightText`. `reuse lint` fails a file carrying only the first, and the copyright holder string is not derivable from the sentence that was there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164
"All source files must include SPDX headers" states no header content. Every
.solin the repo carries two lines, not one:Checked across all 19 tracked
.solfiles — both lines present, byte-identical,in every one.
reuse lintfails a file carrying only the identifier, and the identifier aloneis the shape written from this instruction, since solc itself warns about
nothing else. The copyright holder string is not derivable from the sentence, so
a session had no way to produce a passing file from the doc.
The sentence now says a
.solcopies the two lines its siblings carry. Theissue proposed spelling both strings out inline; pointing at the siblings is
shorter, cannot go stale if the holder string ever changes, and leads to the
same two lines. CLAUDE.md is under a byte cap, which is why the shorter form
wins.
CLAUDE.md is 3829 bytes on this branch against the 4096
agent-context-cap(3807 on main). With all seven CLAUDE.md fixes from this audit batch landed it
comes to 4048.
Textual overlap with the PR closing #114. That one appends a third sentence
to this same paragraph (the
REUSE.toml/.soldeerignorepath lists fornon-source files); this one rewrites the second. Both branch off
mainand eachstands alone; I merge
maininto whichever lands second and resolve.QA
never assert doc text.
src/ortest/code changed..solfiles' first two lines, andREUSE.toml'sannotation block, which supplies the same two fields for the non-source files.
README.mdcarries no licensing instruction, and thedeprecated interfaces' own headers carry the two lines like every other
.sol, so this sentence was the only place the header shape was stated.🤖 Generated with Claude Code