package: ship the annotation that licenses the shipped README - #254
Open
thedavidmeister wants to merge 1 commit into
Open
thedavidmeister wants to merge 1 commit into
thedavidmeister wants to merge 1 commit into
Conversation
README.md carries no SPDX header, so REUSE.toml is its only license declaration, and the package excluded it. reuse lint over a consumer holding the package goes 22/23 -> 23/23. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 39 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #171
.soldeerignoreexcluded/REUSE.tomlfrom the published package.REUSE.tomlis the only thing that licenses
README.md—grep -c SPDX README.mdis 0 —and
README.mdships. So every publishedrain-factoryrevision carries a filewith no license declaration anywhere inside it, in a tree the consumer cannot
edit.
Reproduced on both sides, not inferred.
forge soldeer push --dry-runin thisbranch's worktree now writes
REUSE.tomlinto the zip besideREADME.md,LICENSE,LICENSES/,src/andtest/; before this change the zip had noREUSE.toml. Runningreuse lintover a synthetic consumer holding the packageunder
dependencies/rain-factory-0.0.0/:README.mdis the sole offender before and the only file the annotation isneeded for; the nested
LICENSEandLICENSES/are already found by the tool.The annotation paths that do not ship (
audit/**/,flake.nix, …) do not error— an unmatched annotation path is not a REUSE violation.
.soldeerignoreis also the file #144 and #172 edit, one entry each. Each ofthe three stands alone; #144 adds a line where this one removes one, so
whichever merges second needs a trivial conflict resolution.
QA
from the forge suite. The discriminating evidence is the pair of
reuse lintruns above, which differ only by the presence of the file this PR ships.
src/ortest/change, so there is no behaviourto mutate.
reuse6.x itself over a real consumer-shaped tree, and the zipforge soldeer push --dry-runactually produces, rather than reading theignore list and reasoning about it.
README.mdhaving nolicense declaration; covered A. I checked the general form too - of the
sixteen paths
REUSE.tomlannotates,README.mdis the only one that alsoships today, so shipping the annotation file closes the class, not just the
one instance. The parallel-lists drift that lets a future
REUSE.tomlentryrepeat this is [F56] [INFO]
.soldeerignoreandREUSE.tomlare parallel hand-maintained lists of the same non-source file set, and only one of the two fails loudly when it falls behind #160's subject and is untouched here.🤖 Generated with Claude Code