Skip to content

README: drop the interpreter blurb from the Interfaces section - #255

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-09-21-issue-124-readme-interpreter-boilerplate
Open

thedavidmeister wants to merge 1 commit into
mainfrom
2026-09-21-issue-124-readme-interpreter-boilerplate

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Closes #124

## Interfaces opened with ~20 lines about calling interpreters: what can go
wrong when "any" contract calls one, metamorphic contracts, indexer ABI
discoverability, trusting contracts at the bytecode level, and a pointer to
rain.extrospection. None of it is about this repo. src/ is
ICloneableV2, ICloneableFactoryV4, LibICloneableFactoryV4 and
deprecated/; nothing here calls, imports or names an interpreter — after this
deletion grep -c interpret README.md is 0, and it was 1 only because of that
passage.

It is carryover from a shared blurb, and it sat between the section heading and
the actual interface descriptions, so a reader arriving for the design rationale
of ICloneableV2 / ICloneableFactoryV4 read a different problem domain first.

Deleted, keeping Contains interfaces for working with Rain factories. and the
interface list that follows. Nothing is reworded and nothing is added.

QA

  • Discriminating tests: n/a - README prose, and tests never assert README text.
  • Mutations applied: n/a - no src/ or test/ change, so there is no behaviour
    to mutate.
  • Oracle: the repo's own contents. src/ holds three current interfaces plus
    deprecated/, and no file in the tree references an interpreter or
    rain.extrospection once this passage is gone.
  • Category check: the issue asks for (A) the interpreter passage at 46-64;
    covered A as one contiguous deletion, because the bullets at 52-55 and 57-61
    and the rain.extrospection pointer at 63-64 only make sense as that
    passage's continuation. The rest of the section was read rather than assumed:
    the ## Interfaces line, the one-line summary and the interface list are all
    about this repo and are left alone. The open-salt paraphrase further down the
    same list is a different defect, [F39] [LOW] README.md paraphrases the ICloneableFactoryV4 open-salt spec and has already fallen behind it: it still names tx.origin as the one residual the address cannot fix #143's, and is not touched here.

🤖 Generated with Claude Code

Nothing in this repo calls or names an interpreter; the passage was carryover
sitting between the heading and the interface descriptions.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 38 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 947e4123-f9d6-4be4-bcc3-fd5746526772

📥 Commits

Reviewing files that changed from the base of the PR and between 710dff5 and d5f52c8.

📒 Files selected for processing (1)
  • README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[F20] [LOW] README's Interfaces rationale is about calling interpreters, not about clone factories

1 participant