README: drop the interpreter blurb from the Interfaces section - #255
Open
thedavidmeister wants to merge 1 commit into
Open
thedavidmeister wants to merge 1 commit into
thedavidmeister wants to merge 1 commit into
Conversation
Nothing in this repo calls or names an interpreter; the passage was carryover sitting between the heading and the interface descriptions. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 38 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #124
## Interfacesopened with ~20 lines about calling interpreters: what can gowrong when "any" contract calls one, metamorphic contracts, indexer ABI
discoverability, trusting contracts at the bytecode level, and a pointer to
rain.extrospection. None of it is about this repo.src/isICloneableV2,ICloneableFactoryV4,LibICloneableFactoryV4anddeprecated/; nothing here calls, imports or names an interpreter — after thisdeletion
grep -c interpret README.mdis 0, and it was 1 only because of thatpassage.
It is carryover from a shared blurb, and it sat between the section heading and
the actual interface descriptions, so a reader arriving for the design rationale
of
ICloneableV2/ICloneableFactoryV4read a different problem domain first.Deleted, keeping
Contains interfaces for working with Rain factories.and theinterface list that follows. Nothing is reworded and nothing is added.
QA
src/ortest/change, so there is no behaviourto mutate.
src/holds three current interfaces plusdeprecated/, and no file in the tree references an interpreter orrain.extrospectiononce this passage is gone.covered A as one contiguous deletion, because the bullets at 52-55 and 57-61
and the
rain.extrospectionpointer at 63-64 only make sense as thatpassage's continuation. The rest of the section was read rather than assumed:
the
## Interfacesline, the one-line summary and the interface list are allabout this repo and are left alone. The open-salt paraphrase further down the
same list is a different defect, [F39] [LOW] README.md paraphrases the ICloneableFactoryV4 open-salt spec and has already fallen behind it: it still names tx.origin as the one residual the address cannot fix #143's, and is not touched here.
🤖 Generated with Claude Code