test: assert the shared-tail clauses through cloneDeterministicOpenSalt

[thedavidmeister]

Closes #123

Both entry points funnel into one cloneAndInitialize body, so a mutant of any
tail line is killed by whichever entry point happens to cover it and a
per-entry-point gap is invisible to mutation. The suite's own convention is to
assert shared-tail behaviour through both paths
(checkBothEntryPointsRevert and friends in cloneAndInitialize.t.sol); five
clauses broke it and were pinned through cloneDeterministic only. All five are
now asserted through cloneDeterministicOpenSalt:

• …OpenSaltInitializeIsTheOnlyCall — initialize is the first and only call
  on the fresh proxy, a clause ICloneableFactoryV4 states on
  cloneDeterministicOpenSalt itself.
• …OpenSaltEventPrecedesInitialize — NewClone lands in the log stream before
  the clone's own Initializing.
• …OpenSaltNonceOnlyCollisionReverts — a codeless address with a nonzero nonce
  fails the CREATE2 itself: CloneDeploymentFailed, not
  CloneAddressOccupied. Salts 0 and max take the same branch.
• …OpenSaltCodeGuardRunsBeforeCreate2 — the implementation code guard runs
  ahead of the occupancy check, so an emptied implementation at an occupied
  address reverts ZeroImplementationCodeSize, not CloneAddressOccupied.
• …OpenSaltNoEthForwarded — an ETH-holding factory endows the clone with none
  of it and keeps its balance.

The issue named four. The fifth is …CodeGuardRunsBeforeCreate2, which the
verifier flagged as breaking the same property; the category is the property,
not the list.

QA

• Discriminating tests: the five above
  (test/src/lib/LibICloneableFactoryV4.cloneDeterministicOpenSalt.t.sol).
• Mutations applied: 5, one per clause, each to the shared tail in
  src/lib/LibICloneableFactoryV4.sol — (1) create2(selfbalance(), …) for
  value, (2) delete the child == address(0) → CloneDeploymentFailed branch,
  (3) move emit NewClone after the initialize call, (4) insert a
  child.call("") before initialize, (5) move checkImplementationCode after
  the occupancy check. Every one SURVIVES on main: the open-salt file is 17
  passed / 0 failed under all five. On this branch each one leaves 21 passed / 1
  failed, and the single failure is its own clause's test —
  (1) …NoEthForwarded, (2) …NonceOnlyCollisionReverts,
  (3) …EventPrecedesInitialize, (4) …InitializeIsTheOnlyCall,
  (5) …CodeGuardRunsBeforeCreate2. Unmutated, the whole suite is 83 passed / 0
  failed.
• Oracle: src/interface/ICloneableFactoryV4.sol, whose call-ordering and
  occupancy clauses are written on cloneDeterministicOpenSalt itself, so they
  are claims about that function and not only about the tail it shares.
• Category check: the category is "a shared-tail clause pinned through one
  entry point only", checked in both directions. Namespaced-only after this PR:
  …SenderScoped, …SaltIsDomainTaggedHash, …DataNotInDerivation,
  …PredictZeroDeployer, …SecondDeployDifferentDataReverts — all properties
  of the namespaced DERIVATION, which the open-salt path does not have — and
  …InitializeRevertBubbles, whose clause is already pinned through both paths
  by checkBothEntryPointsRevert(true, revertData, …) in
  cloneAndInitialize.t.sol. Open-salt-only: …CallerIndependent,
  …DataInDerivation, …DiffersFromSenderNamespaced,
  …DoesNotConsumeNamespacedSalt, …IsDomainTaggedHash, …EmptyData,
  …LargeData — all open-salt derivation properties. No tail clause is left on
  one side.

Touches test/src/lib/LibICloneableFactoryV4.cloneDeterministicOpenSalt.t.sol,
as does the PR for #166 — both branch off main; this one changes the imports
and the tail of the file, #166 the body of
…OpenSaltInitializeFailureFails.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

Next included review available in 29 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ae527504-46d4-408c-875a-c11b42a53168

📥 Commits

Reviewing files that changed from the base of the PR and between f2d9e5a and 725f870.

📒 Files selected for processing (1)

• test/src/lib/LibICloneableFactoryV4.cloneDeterministicOpenSalt.t.sol

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}