Skip to content

refactor: name the agree guard validateAgreeTolerances #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thedavidmeister wants to merge 1 commit into from
Closed

refactor: name the agree guard validateAgreeTolerances #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/LibDecimalFloat.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ library LibDecimalFloat {
/// @param highest The highest value in the set.
/// @return Whether the spread is within the limit.
function agree(Float absolute, Float proportional, Float lowest, Float highest) internal pure returns (bool) {
agreeValidateTolerances(absolute, proportional);
validateAgreeTolerances(absolute, proportional);
(int256 spreadCoefficient, int256 spreadExponent) = agreeSpread(lowest, highest);
(int256 limitCoefficient, int256 limitExponent) = agreeLimit(absolute, proportional, lowest, highest);
return LibDecimalFloatImplementation.lte(spreadCoefficient, spreadExponent, limitCoefficient, limitExponent);
Expand Down Expand Up @@ -955,7 +955,7 @@ library LibDecimalFloat {
/// the negative check is ever changed.
/// @param absolute The absolute tolerance.
/// @param proportional The proportional tolerance.
function agreeValidateTolerances(Float absolute, Float proportional) private pure {
function validateAgreeTolerances(Float absolute, Float proportional) private pure {
Float zero = packLossless(0, 0);
if (lt(absolute, zero) || lt(proportional, zero)) {
revert AgreeToleranceNegative(absolute, proportional);
Expand Down
Loading