Skip to content

call block tag - #493

Merged
rouzwelt merged 4 commits into
masterfrom
2026-09-14-call-block-time
Sep 23, 2026
Merged

rouzwelt merged 4 commits into
masterfrom
2026-09-14-call-block-time

Conversation

@rouzwelt

@rouzwelt rouzwelt commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

  • New Features

    • Added configurable block tags for order quotes and gas estimates: latest, earliest, pending, safe, or finalized.
    • Added support for recognizing the Robinhood oracle context URL.
    • Documented the new optional configuration setting and its accepted values.
  • Bug Fixes

    • Round completion now reliably includes pending metadata, including recording metadata reporting errors instead of silently losing them.

@rouzwelt rouzwelt self-assigned this Sep 16, 2026
@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5da912fa-f71a-4c2e-bec7-19828b712626

📥 Commits

Reviewing files that changed from the base of the PR and between 7a3b8f7 and aa627fa.

📒 Files selected for processing (11)
  • config.env.yaml
  • config.example.yaml
  • src/cli/index.test.ts
  • src/cli/index.ts
  • src/config/yaml.test.ts
  • src/config/yaml.ts
  • src/oracle/types.ts
  • src/order/quote.test.ts
  • src/order/quote.ts
  • src/signer/actions.test.ts
  • src/signer/actions.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change adds optional call block tag configuration for quote and gas estimate calls, ensures round metadata reporting completes before span closure, and registers a new known oracle context URL.

Changes

Configurable call block tags

Layer / File(s) Summary
Call block tag configuration
src/config/yaml.ts, config.env.yaml, config.example.yaml, src/config/yaml.test.ts
AppOptions accepts five case-insensitive call block tags. Environment values and YAML values are validated. Unset values produce no explicit block tag.
Quote and gas estimate integration
src/order/quote.ts, src/order/quote.test.ts, src/signer/actions.ts, src/signer/actions.test.ts
Quote and gas estimate calls use the configured block tag. Tests cover configured and unset values for V3, V4, and gas estimation calls.

Round metadata completion

Layer / File(s) Summary
Metadata reporting and round finalization
src/cli/index.ts, src/cli/index.test.ts
Round finalization receives the metadata report promise and waits for it before ending the span. Reporting failures set the meta.error span attribute. Tests cover promise completion and metadata attributes.

Known oracle URL

Layer / File(s) Summary
Oracle endpoint registration
src/oracle/types.ts
The Robinhood oracle context URL is added to the known URL list.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant AppOptions
  participant quoteSingleOrder
  participant estimateGasCost
  participant RPCClient
  AppOptions-->>quoteSingleOrder: provide optional blockTag
  quoteSingleOrder->>RPCClient: issue eth_call
  AppOptions-->>estimateGasCost: provide optional blockTag
  estimateGasCost->>RPCClient: issue eth_estimateGas
Loading

Merge Risk: ⚪ Minimal · up to aa627

No merge-blocking behavior change is currently identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 9 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: adding configurable call block tag support for quote and gas estimation calls.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 9 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rouzwelt rouzwelt changed the title call block time call block tag Sep 23, 2026
@linear

linear Bot commented Sep 23, 2026

Copy link
Copy Markdown

RAI-2575

@rouzwelt
rouzwelt changed the base branch from 2026-09-13-sg-query-schema-update to master September 23, 2026 01:30
@rouzwelt
rouzwelt merged commit 5127875 into master Sep 23, 2026
4 of 12 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

This branch is being deployed

1 in progress deployment
preview — aa627fa5 Deployed Sep 23, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant