Skip to content

oracle t0 subdomain support - #494

Merged
rouzwelt merged 3 commits into
masterfrom
2026-09-14-oracle-t0-subdomain-support
Sep 24, 2026
Merged

rouzwelt merged 3 commits into
masterfrom
2026-09-14-oracle-t0-subdomain-support

Conversation

@rouzwelt

@rouzwelt rouzwelt commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Summary by CodeRabbit

  • New Features
    • Oracle URL recognition now includes HTTPS URLs on t0trade.com and its subdomains, including URLs with varied capitalization. Lookalike hostnames, non-HTTPS URLs, and invalid URLs are not accepted.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3bee68e4-2db5-4ee1-b7f0-113551417332

📥 Commits

Reviewing files that changed from the base of the PR and between 5127875 and 03fcbfc.

📒 Files selected for processing (4)
  • src/core/process/order.test.ts
  • src/core/process/order.ts
  • src/oracle/types.test.ts
  • src/oracle/types.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change expands recognition of HTTPS URLs on t0trade.com and its subdomains. It also records oracle URLs under details.oracle.url in order-processing spans.

Changes

Known oracle URL recognition

Layer / File(s) Summary
Known oracle URL matching
src/oracle/types.ts, src/oracle/types.test.ts
OracleConstants.isKnown accepts matching known URL prefixes and HTTPS hostnames on t0trade.com or its subdomains. Tests cover accepted URLs, lookalike hosts, and invalid inputs.

Oracle URL span attribute

Layer / File(s) Summary
Record oracle URL span attribute
src/core/process/order.ts, src/core/process/order.test.ts
processOrder records the oracle URL as details.oracle.url. The test expects the updated attribute key.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: support for Oracle T0 subdomains. It is concise and related to the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rouzwelt rouzwelt changed the title 2026 09 14 oracle t0 subdomain support oracle t0 subdomain support Sep 16, 2026
@linear

linear Bot commented Sep 23, 2026

Copy link
Copy Markdown

RAI-2562

@rouzwelt
rouzwelt changed the base branch from 2026-09-14-call-block-time to master September 23, 2026 22:51
@rouzwelt
rouzwelt merged commit a4f1cc3 into master Sep 24, 2026
4 of 12 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

This branch is being deployed

1 in progress deployment
preview — 03fcbfc1 Deployed Sep 23, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant