Bump rain-sol-codegen 0.1.37 with rainlang 0.2.6, rainlang-interface 0.2.9, rain-deploy 0.1.10 and the transitive pins rainlang 0.2.6 imports - #6
Merged
Conversation
…9, rain-deploy 0.1.10, rain-lib-typecast 0.1.4, rain-math-float 0.2.1, rain-metadata 0.1.7; add rain-math-float-deploy 0.1.2 rainlang 0.2.6 hard-imports the four transitive pins at these versions and recursive_deps is off. LibDecimalFloatDeploy moved to rain-math-float-deploy in the float split. The rain-deploy-0.1.7 alias remapping is dead now that rainlang imports 0.1.10 directly. Build.sol regenerated: parser, interpreter, expression deployer and Rainlang candidates moved; store unchanged. flake.lock takes rain.cli 91d70ac (fetchCargoVendor); HEAD bce8de4 has a stale cargoHash and does not build. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V8ViHcKLVk2YoS2joH4HdN
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (19)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe project updates dependency versions and removes an obsolete Rain Deploy remapping. Production scripts, contracts, and tests now import the corresponding symbols from the newer package versions. ChangesDependency Version Alignment
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The change aligns dependency versions and import paths without modifying production logic, and no actionable merge-blocking risk is evidenced. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps rain-sol-codegen 0.1.36 -> 0.1.37 together with the pinned packages that import it: rainlang 0.2.1 -> 0.2.6, rainlang-interface 0.2.8 -> 0.2.9, rain-deploy 0.1.8 -> 0.1.10.
rainlang 0.2.6 hard-imports four transitive packages at versions this repo did not pin, and
recursive_depsis off, so those move with it: rain-lib-typecast 0.1.0 -> 0.1.4, rain-math-float 0.1.1 -> 0.2.1, rain-metadata 0.1.0 -> 0.1.7, and rain-math-float-deploy 0.1.2 added (LibDecimalFloatDeploymoved there from rain-math-float in the float split; the two imports here follow it).The
rain-deploy-0.1.7/->0.1.8/alias remapping in foundry.toml is removed: rainlang 0.2.6 imports rain-deploy-0.1.10 directly, so nothing aliases any more.Every versioned import under src, script and test is rewritten to the new paths;
soldeer.lockfollows.script/Build.solwas re-run after the bump, sosrc/generated/candidate/and the*Pointers.soltables reflect the rainlang 0.2.6 sources. Frozensrc/generated/<tag>/dirs are untouched. Nothing is deployed by this PR.flake.lock takes rain.cli 91d70ac, the commit that vendors crates through fetchCargoVendor so the devshell no longer 403s on crates.io (rainlanguage/rainix#377). The later rain.cli HEAD bce8de4 is a release version bump with a stale cargoHash and does not build, which is why the lock stops at 91d70ac.
Why
The org health dashboard flags the rain-sol-codegen, rainlang, rainlang-interface and rain-deploy pins as stale. Published packages hard-import the versioned codegen path and soldeer keeps one version per package, so codegen 0.1.37 can only land once every pinned importer is on a release built against it.
QA
Build.soland pass after it.git diffscope limited to foundry.toml, soldeer.lock, flake.lock, versioned import paths andBuild.soloutput.🤖 Generated with Claude Code
https://claude.ai/code/session_01V8ViHcKLVk2YoS2joH4HdN
Summary by CodeRabbit
Dependencies
Compatibility