Repository navigation
fix(assistant): stabilize nightly source and input interactions - #288
Merged
Merged
Conversation
Deploying document with
|
| Latest commit: |
3849357
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6bbb972.document-7hm.pages.dev |
| Branch Preview URL: | https://codex-nightly-interaction-st.document-7hm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Verdict
[APPROVE] — Address the three retry-only failures from PR #287's nightly run with one narrow source-ownership fix and deterministic browser regressions.
Summary
Risk Analysis
Design Decisions
skip_corpus=true.Code Concerns
No outstanding actionable findings after independent review and caller tracing through history controls, conversation selection and captured-reference consumers.
Verification
3849357c51aa553cd25cea56965ec8f041da97a4All focused browser runs used zero retries.
All 19 PR checks are successful for
3849357c51aa553cd25cea56965ec8f041da97a4. All three originally flaky scenarios passed on their first CI execution, including the retained fault-injection regressions. All eight nightly browser report artifacts were retained. The weekly real-document corpus was intentionally omitted withskip_corpus=true.Preview: this commit's deployment.
Reverse validation
[]instead of['New notes']; the browser's controlled startup restoration removes the attachednotes.txtrow.1449instead of0after resize.""instead of"Recovery version".The implementation notes and boundaries are recorded in
docs/explorations/2026-10-20-nightly-interaction-stability.md.