Skip to content

Fix Ruff findings - #723

Merged
razzeee merged 1 commit into
fix-trakt-auth-hostfrom
fix-ruff-rule-drift
Oct 23, 2026
Merged

razzeee merged 1 commit into
fix-trakt-auth-hostfrom
fix-ruff-rule-drift

Conversation

@razzeee

@razzeee razzeee commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Fix the Ruff findings exposed by the newer CI Ruff release.
  • Keep Ruff configuration unchanged.
  • Preserve broad exception boundaries where they are intentional and documented.

Validation

  • Ruff 0.17.2 check and format checks pass.
  • 139 tests pass.

@coveralls

coveralls commented Oct 23, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 39950760143

Warning

No base build found for commit 79ac7c9 on fix-trakt-auth-host.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 54.561%

Details

  • Patch coverage: 43 uncovered changes across 4 files (111 of 154 lines covered, 72.08%).

Uncovered Changes

File Changed Covered %
resources/lib/utilities.py 57 37 64.91%
resources/lib/kodiUtilities.py 28 16 57.14%
resources/lib/traktapi.py 61 53 86.89%
resources/lib/deviceAuthDialog.py 6 3 50.0%
Total (5 files) 154 111 72.08%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 1206
Covered Lines: 658
Line Coverage: 54.56%
Coverage Strength: 0.55 hits per line

💛 - Coveralls

@razzeee
razzeee force-pushed the fix-ruff-rule-drift branch from 0065823 to 867dd9e Compare October 23, 2026 10:48
@razzeee
razzeee force-pushed the fix-ruff-rule-drift branch from 867dd9e to 8a41029 Compare October 23, 2026 12:05
@razzeee razzeee changed the title Pin Ruff checks to the intended rules Fix Ruff findings Oct 23, 2026
@razzeee
razzeee merged commit 21cfbf4 into fix-trakt-auth-host Oct 23, 2026
2 checks passed
@razzeee
razzeee deleted the fix-ruff-rule-drift branch October 23, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants