Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #1221.
Use
<React/RCTBridge.h>inMenuViewManager.mm, matching the other React imports in this file. The unqualified include fails with the RN 0.87+ header layout; the header itself is still available. This is the same qualified import confirmed in the issue.The change is limited to header lookup. It preserves the existing import and leaves both architecture implementations and Android unchanged.
Test Plan
Built the iOS simulator Debug app with Xcode 27 and code signing disabled:
yarn typescriptandyarn biome lint .pass.yarn test --runInBandpasses, though the existing suite contains only a todo test. Validation covers compilation; I did not run menu interaction tests for this header-only change.