Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126331456. |
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D126331456
branch
from
October 27, 2026 09:45
40092e2 to
7f30692
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Oct 27, 2026
Summary: Run `spm add` with `RN_STRICT_API=1` in the three SwiftPM CI jobs (RN-Tester, helloworld and the new-app flow), so the SwiftPM opt-in is exercised the way an app enables it. `spm add` records the choice in `.spm-injected.json` and defines `RN_STRICT_API` for the app target, the `spm.modules` packages (RN-Tester's sample native modules) and the app's codegen package. This depends on the C++ stable API guards being `textual header` members of the prebuilt `ReactNativeHeaders` module map. Changelog: [Internal] Differential Revision: D126331456
Visual regression1 visual difference(s) at ios
|
| Expected | Captured |
|---|---|
 |
 |
Summary: Run `spm add` with `RN_STRICT_API=1` in the three SwiftPM CI jobs (RN-Tester, helloworld and the new-app flow), so the SwiftPM opt-in is exercised the way an app enables it. `spm add` records the choice in `.spm-injected.json` and defines `RN_STRICT_API` for the app target, the `spm.modules` packages (RN-Tester's sample native modules) and the app's codegen package. This depends on the C++ stable API guards being `textual header` members of the prebuilt `ReactNativeHeaders` module map. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D126331456
coado
force-pushed
the
export-D126331456
branch
from
October 30, 2026 09:01
7f30692 to
0012af2
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Run
spm addwithRN_STRICT_API=1in the three SwiftPM CI jobs (RN-Tester, helloworld and the new-app flow), so the SwiftPM opt-in is exercised the way an app enables it.spm addrecords the choice in.spm-injected.jsonand definesRN_STRICT_APIfor the app target, thespm.modulespackages (RN-Tester's sample native modules) and the app's codegen package.This depends on the C++ stable API guards being
textual headermembers of the prebuiltReactNativeHeadersmodule map.Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D126331456